Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Side by Side Diff: Source/core/rendering/RenderLayerModelObject.cpp

Issue 448793002: Unified invalidation for repaint-only style change of layers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Test expectations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010, 2012 Google Inc. All rights reserved. 7 * Copyright (C) 2010, 2012 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 83
84 RenderObject::willBeDestroyed(); 84 RenderObject::willBeDestroyed();
85 85
86 destroyLayer(); 86 destroyLayer();
87 } 87 }
88 88
89 void RenderLayerModelObject::styleWillChange(StyleDifference diff, const RenderS tyle& newStyle) 89 void RenderLayerModelObject::styleWillChange(StyleDifference diff, const RenderS tyle& newStyle)
90 { 90 {
91 s_wasFloating = isFloating(); 91 s_wasFloating = isFloating();
92 92
93 // If our z-index changes value or our visibility changes, 93 if (RenderStyle* oldStyle = style()) {
94 // we need to dirty our stacking context's z-order list.
95 RenderStyle* oldStyle = style();
96 if (oldStyle) {
97 // Do a repaint with the old style first through RenderLayerRepainter.
98 // RenderObject::styleWillChange takes care of repainting objects withou t RenderLayers.
99 if (parent() && diff.needsRepaintLayer()) { 94 if (parent() && diff.needsRepaintLayer()) {
100 // This is currently need to make non-layout-requiring updates work that impact descendant layers,
101 // such as changes to opacity or transform.
102 layer()->repainter().repaintIncludingNonCompositingDescendants();
103 if (oldStyle->hasClip() != newStyle.hasClip() 95 if (oldStyle->hasClip() != newStyle.hasClip()
104 || oldStyle->clip() != newStyle.clip()) 96 || oldStyle->clip() != newStyle.clip())
105 layer()->clipper().clearClipRectsIncludingDescendants(); 97 layer()->clipper().clearClipRectsIncludingDescendants();
106 } 98 }
107 } 99 }
108 100
109 RenderObject::styleWillChange(diff, newStyle); 101 RenderObject::styleWillChange(diff, newStyle);
110 } 102 }
111 103
112 void RenderLayerModelObject::styleDidChange(StyleDifference diff, const RenderSt yle* oldStyle) 104 void RenderLayerModelObject::styleDidChange(StyleDifference diff, const RenderSt yle* oldStyle)
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 InvalidationReason reason = invalidatePaintIfNeeded(paintInvalidationState, newPaintInvalidationContainer); 200 InvalidationReason reason = invalidatePaintIfNeeded(paintInvalidationState, newPaintInvalidationContainer);
209 201
210 PaintInvalidationState childTreeWalkState(paintInvalidationState, *this, new PaintInvalidationContainer); 202 PaintInvalidationState childTreeWalkState(paintInvalidationState, *this, new PaintInvalidationContainer);
211 if (reason == InvalidationLocationChange || reason == InvalidationFull) 203 if (reason == InvalidationLocationChange || reason == InvalidationFull)
212 childTreeWalkState.setForceCheckForPaintInvalidation(); 204 childTreeWalkState.setForceCheckForPaintInvalidation();
213 RenderObject::invalidateTreeIfNeeded(childTreeWalkState); 205 RenderObject::invalidateTreeIfNeeded(childTreeWalkState);
214 } 206 }
215 207
216 } // namespace blink 208 } // namespace blink
217 209
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698