Chromium Code Reviews| Index: chrome/telemetry_gpu_test.isolate |
| diff --git a/chrome/telemetry_gpu_test.isolate b/chrome/telemetry_gpu_test.isolate |
| index be360df6e1e1b12deec0550580abe08d295b625d..0c0a0b1cd52ddc0b588d4dad38eebe33a59a74db 100644 |
| --- a/chrome/telemetry_gpu_test.isolate |
| +++ b/chrome/telemetry_gpu_test.isolate |
| @@ -24,10 +24,26 @@ |
| ], |
| }, |
| }], |
| - # For debugging crbug.com/383963 |
| - ['OS=="win" and (fastbuild==0 or fastbuild==1)', { |
| + # These PDBs are needed in order to get reasonable stack traces if |
| + # an assertion fires or a crash occurs. Add more as necessary. |
| + ['OS=="win" and component=="shared_library" and (fastbuild==0 or fastbuild==1)', { |
|
Ken Russell (switch to Gerrit)
2014/08/06 17:32:18
Not sure how to split this to match the 80 column
M-A Ruel
2014/08/06 17:34:43
That's fine.
I'm wondering if we should map these
|
| 'variables': { |
| 'isolate_dependency_tracked': [ |
| + '<(PRODUCT_DIR)/base.dll.pdb', |
| + '<(PRODUCT_DIR)/blink_platform.dll.pdb', |
| + '<(PRODUCT_DIR)/blink_web.dll.pdb', |
| + '<(PRODUCT_DIR)/chrome.dll.pdb', |
| + '<(PRODUCT_DIR)/chrome.exe.pdb', |
| + '<(PRODUCT_DIR)/chrome_child.dll.pdb', |
| + '<(PRODUCT_DIR)/content.dll.pdb', |
| + ], |
| + }, |
| + }], |
| + ['OS=="win" and component=="static_library" and (fastbuild==0 or fastbuild==1)', { |
| + 'variables': { |
| + 'isolate_dependency_tracked': [ |
| + '<(PRODUCT_DIR)/chrome.dll.pdb', |
|
M-A Ruel
2014/08/06 17:34:43
Technically, you'd want these in a condition:
'OS
Ken Russell (switch to Gerrit)
2014/08/06 17:42:18
Thanks, good suggestion. Done.
|
| + '<(PRODUCT_DIR)/chrome.exe.pdb', |
| '<(PRODUCT_DIR)/chrome_child.dll.pdb', |
| ], |
| }, |