Added more PDBs to telemetry_gpu_test.isolate.

Added more PDBs to telemetry_gpu_test.isolate.

If new assertions fire or crashes occur, these PDBs are needed in
order to generate reasonable stack traces. Remove the comment about
their presence being temporary.

BUG=383963, 385976
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287882

[Ken Russell (switch to Gerrit), 2014-08-06 17:32:18]

Chris, Marc-Antoine: please review.

I posted a list of the sizes of these PDBs for the Release build on
http://crbug.com/385976 . While they're not small -- chrome.dll.pdb is about 122
MB -- it's important that they be included because when an assertion fires or
crash occurs a stack trace is all that's available for debugging.

https://codereview.chromium.org/448773002/diff/20001/chrome/telemetry_gpu_tes...
File chrome/telemetry_gpu_test.isolate (right):

https://codereview.chromium.org/448773002/diff/20001/chrome/telemetry_gpu_tes...
chrome/telemetry_gpu_test.isolate:29: ['OS=="win" and
component=="shared_library" and (fastbuild==0 or fastbuild==1)', {
Not sure how to split this to match the 80 column rule.

[M-A Ruel, 2014-08-06 17:34:43]

lgtm with comment, as you prefer.

https://codereview.chromium.org/448773002/diff/20001/chrome/telemetry_gpu_tes...
File chrome/telemetry_gpu_test.isolate (right):

https://codereview.chromium.org/448773002/diff/20001/chrome/telemetry_gpu_tes...
chrome/telemetry_gpu_test.isolate:29: ['OS=="win" and
component=="shared_library" and (fastbuild==0 or fastbuild==1)', {
On 2014/08/06 17:32:18, Ken Russell wrote:
> Not sure how to split this to match the 80 column rule.

That's fine.

I'm wondering if we should map these all the time, so that it'd go in
chrome.isolate. We can decide this later.

https://codereview.chromium.org/448773002/diff/20001/chrome/telemetry_gpu_tes...
chrome/telemetry_gpu_test.isolate:45: '<(PRODUCT_DIR)/chrome.dll.pdb',
Technically, you'd want these in a condition:

'OS=="win" and (fastbuild==0 or fastbuild== 1)'

e.g. they are mapped independent of the value of component.

[Ken Russell (switch to Gerrit), 2014-08-06 17:42:18]

https://codereview.chromium.org/448773002/diff/20001/chrome/telemetry_gpu_tes...
File chrome/telemetry_gpu_test.isolate (right):

https://codereview.chromium.org/448773002/diff/20001/chrome/telemetry_gpu_tes...
chrome/telemetry_gpu_test.isolate:45: '<(PRODUCT_DIR)/chrome.dll.pdb',
On 2014/08/06 17:34:43, M-A Ruel wrote:
> Technically, you'd want these in a condition:
> 
> 'OS=="win" and (fastbuild==0 or fastbuild== 1)'
> 
> e.g. they are mapped independent of the value of component.

Thanks, good suggestion. Done.

[Ken Russell (switch to Gerrit), 2014-08-06 17:42:57]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2014-08-06 17:43:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kbr@chromium.org/448773002/40001

[commit-bot: I haz the power, 2014-08-06 22:51:10]

Change committed as 287882