Issue 448763003: Remove wstring file path helpers from test_file_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 448763003: Remove wstring file path helpers from test_file_util. (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove wstring file path helpers from test_file_util. These were only used by one test file, so I moved the implementation there. I considered updating the test, but the way the test uses wstrings seems reasonable. R=rvargas@chromium.org, rvargas Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288084

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -27 lines)			Patch
M	base/test/test_file_util.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	base/test/test_file_util_posix.cc	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	base/test/test_file_util_win.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	net/base/filename_util_unittest.cc	View	3 chunks	+20 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 4 months ago (2014-08-07 16:53:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 288084 (presubmit successful).