Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 448743003: gn win: Add breakpad_handler target, necessary to compile breakpad on win (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

gn win: Add breakpad_handler target, necessary to compile breakpad on win (due to direct_dependent include_dirs) R=brettw@chromium.org TBR=thestig@chromium.org BUG=354261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287930

Patch Set 1 #

Patch Set 2 : only win #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M breakpad/BUILD.gn View 1 2 chunks +31 lines, -0 lines 0 comments Download
M components/breakpad/app/BUILD.gn View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
scottmg
6 years, 4 months ago (2014-08-06 17:59:50 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-06 18:24:41 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-06 18:30:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/448743003/1
6 years, 4 months ago (2014-08-06 18:31:57 UTC) #4
scottmg
The CQ bit was unchecked by scottmg@chromium.org
6 years, 4 months ago (2014-08-06 18:32:51 UTC) #5
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-06 20:40:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/448743003/20001
6 years, 4 months ago (2014-08-06 20:42:32 UTC) #7
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-06 20:48:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/448743003/40001
6 years, 4 months ago (2014-08-06 20:49:01 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 23:17:05 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 23:41:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3090)
6 years, 4 months ago (2014-08-06 23:41:34 UTC) #12
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-08-06 23:44:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/448743003/40001
6 years, 4 months ago (2014-08-06 23:45:53 UTC) #14
commit-bot: I haz the power
Change committed as 287930
6 years, 4 months ago (2014-08-07 02:28:01 UTC) #15
Lei Zhang
lgtm (please add TBR'd folks to the review)
6 years, 4 months ago (2014-08-11 21:03:34 UTC) #16
scottmg
6 years, 4 months ago (2014-08-11 21:09:40 UTC) #17
Message was sent while issue was closed. 
On 2014/08/11 21:03:34, Lei Zhang wrote:
> lgtm (please add TBR'd folks to the review)

Oops, sorry. I thought I did. Thanks for looking.

Powered by Google App Engine
This is Rietveld 408576698