DevTools: Linkify console stacks with blackboxing consideration.

Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 178 matching lines @@
                     }
                     this._messageElement = this._format([consoleMessage.messageText]);
                 }
             } else {
                 var args = consoleMessage.parameters || [consoleMessage.messageText];
                 this._messageElement = this._format(args);
             }
         }
 
         if (consoleMessage.source !== WebInspector.ConsoleMessage.MessageSource.Network || consoleMessage.request) {
-            var callFrame = this._callFrameAnchorFromStackTrace(consoleMessage.stackTrace);
+            var callFrame = this._callFrameAnchorFromStackTrace(consoleMessage.stackTrace, consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.ConsoleAPI);
             if (callFrame)
                 this._anchorElement = this._linkifyCallFrame(callFrame);
             else if (consoleMessage.url && consoleMessage.url !== "undefined")
                 this._anchorElement = this._linkifyLocation(consoleMessage.url, consoleMessage.line, consoleMessage.column);
         }
 
         this._formattedMessage.appendChild(this._messageElement);
         if (this._anchorElement) {
             this._formattedMessage.appendChild(document.createTextNode(" "));
             this._formattedMessage.appendChild(this._anchorElement);
@@ skipping 68 matching lines @@
         console.assert(this._linkifier);
         var target = this._target();
         if (!this._linkifier)
             return null;
 
         return this._linkifier.linkifyConsoleCallFrame(target, callFrame, "console-message-url");
     },
 
     /**
      * @param {?Array.<!ConsoleAgent.CallFrame>} stackTrace
+     * @param {boolean} isConsoleAPI
      * @return {?ConsoleAgent.CallFrame}
      */
-    _callFrameAnchorFromStackTrace: function(stackTrace)
+    _callFrameAnchorFromStackTrace: function(stackTrace, isConsoleAPI)

[vsevik, 2014/08/08 08:55:50]

I would call this flag useBlackboxing instead.

[aandrey, 2014/08/08 10:05:56]

Done.

     {
         if (!stackTrace || !stackTrace.length)
             return null;
         var callFrame = stackTrace[0].scriptId ? stackTrace[0] : null;
+        if (!isConsoleAPI)
+            return callFrame;
         if (!WebInspector.experimentsSettings.frameworksDebuggingSupport.isEnabled())
             return callFrame;
-        var regex = WebInspector.settings.skipStackFramesPattern.asRegExp();
-        if (!regex)
-            return callFrame;
         for (var i = 0; i < stackTrace.length; ++i) {
-            var script = this._target().debuggerModel.scriptForId(stackTrace[i].scriptId);
-            if (!script || !regex.test(script.sourceURL))
+            if (!WebInspector.BlackboxSupport.isBlackboxedURL(stackTrace[i].url))
                 return stackTrace[i].scriptId ? stackTrace[i] : null;
         }
         return callFrame;
     },
 
     /**
      * @return {boolean}
      */
     isErrorOrWarning: function()
     {
@@ skipping 743 matching lines @@
                 return;
 
             for (var i = 0; i < stackTrace.length; i++) {
                 var frame = stackTrace[i];
 
                 var content = document.createElementWithClass("div", "stacktrace-entry");
                 var functionName = frame.functionName || WebInspector.UIString("(anonymous function)");
                 content.createChild("span", "console-message-text source-code").textContent = functionName;
 
                 if (frame.scriptId) {
-                    content.createTextChild(" ");
                     var urlElement = this._linkifyCallFrame(frame);
                     if (!urlElement)
                         continue;
+                    content.createTextChild(" ");
                     content.appendChild(urlElement);
                 }
 
                 parentTreeElement.appendChild(new TreeElement(content));
             }
         }
 
         appendStackTrace.call(this, this._message.stackTrace);
 
         for (var asyncTrace = this._message.asyncStackTrace; asyncTrace; asyncTrace = asyncTrace.asyncStackTrace) {
@@ skipping 178 matching lines @@
     {
         if (!this._wrapperElement) {
             WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this);
             this._wrapperElement.classList.toggle("collapsed", this._collapsed);
         }
         return this._wrapperElement;
     },
 
     __proto__: WebInspector.ConsoleViewMessage.prototype
 }