DevTools: Linkify console stacks with blackboxing consideration.

Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 178 matching lines @@
                     }
                     this._messageElement = this._format([consoleMessage.messageText]);
                 }
             } else {
                 var args = consoleMessage.parameters || [consoleMessage.messageText];
                 this._messageElement = this._format(args);
             }
         }
 
         if (consoleMessage.source !== WebInspector.ConsoleMessage.MessageSource.Network || consoleMessage.request) {
-            var callFrame = this._callFrameAnchorFromStackTrace(consoleMessage.stackTrace);
-            if (callFrame)
-                this._anchorElement = this._linkifyCallFrame(callFrame);
-            else if (consoleMessage.url && consoleMessage.url !== "undefined")
+            console.assert(this._linkifier);
+            if (this._linkifier)
+                this._anchorElement = this._linkifier.linkifyTopUnblackboxedConsoleCallFrame(this._target(), consoleMessage.stackTrace, "console-message-url", true);

[vsevik, 2014/08/07 09:11:58]

I don't think we should update the console message link unless this message is a
result of console API call.

[aandrey, 2014/08/07 10:24:59]

I'm not sure I follow you here.
Anyway, I did't change the behavior here.

+            if (!this._anchorElement && consoleMessage.url && consoleMessage.url !== "undefined")
                 this._anchorElement = this._linkifyLocation(consoleMessage.url, consoleMessage.line, consoleMessage.column);
         }
 
         this._formattedMessage.appendChild(this._messageElement);
         if (this._anchorElement) {
             this._formattedMessage.appendChild(document.createTextNode(" "));
             this._formattedMessage.appendChild(this._anchorElement);
         }
 
         var dumpStackTrace = !!consoleMessage.stackTrace && consoleMessage.stackTrace.length && (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error || consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trace);
@@ skipping 35 matching lines @@
     /**
      * @param {string} url
      * @param {number} lineNumber
      * @param {number} columnNumber
      * @return {?Element}
      */
     _linkifyLocation: function(url, lineNumber, columnNumber)
     {
         console.assert(this._linkifier);
         var target = this._target();
-        if (!this._linkifier || !target)
+        if (!this._linkifier)
             return null;
         // FIXME(62725): stack trace line/column numbers are one-based.
         lineNumber = lineNumber ? lineNumber - 1 : 0;
         columnNumber = columnNumber ? columnNumber - 1 : 0;
         if (this._message.source === WebInspector.ConsoleMessage.MessageSource.CSS) {
+            if (!target)
+                return null;
             var headerIds = target.cssModel.styleSheetIdsForURL(url);
             var cssLocation = new WebInspector.CSSLocation(target, headerIds[0] || null, url, lineNumber, columnNumber);
             return this._linkifier.linkifyCSSLocation(cssLocation, "console-message-url");
         }
 
         return this._linkifier.linkifyScriptLocation(target, null, url, lineNumber, columnNumber, "console-message-url");
     },
 
     /**
-     * @param {!ConsoleAgent.CallFrame} callFrame
-     * @return {?Element}
-     */
-    _linkifyCallFrame: function(callFrame)
-    {
-        console.assert(this._linkifier);
-        var target = this._target();
-        if (!this._linkifier)
-            return null;
-
-        return this._linkifier.linkifyConsoleCallFrame(target, callFrame, "console-message-url");
-    },
-
-    /**
-     * @param {?Array.<!ConsoleAgent.CallFrame>} stackTrace
-     * @return {?ConsoleAgent.CallFrame}
-     */
-    _callFrameAnchorFromStackTrace: function(stackTrace)
-    {
-        if (!stackTrace || !stackTrace.length)
-            return null;
-        var callFrame = stackTrace[0].scriptId ? stackTrace[0] : null;
-        if (!WebInspector.experimentsSettings.frameworksDebuggingSupport.isEnabled())
-            return callFrame;
-        var regex = WebInspector.settings.skipStackFramesPattern.asRegExp();
-        if (!regex)
-            return callFrame;
-        for (var i = 0; i < stackTrace.length; ++i) {
-            var script = this._target().debuggerModel.scriptForId(stackTrace[i].scriptId);
-            if (!script || !regex.test(script.sourceURL))
-                return stackTrace[i].scriptId ? stackTrace[i] : null;
-        }
-        return callFrame;
-    },
-
-    /**
      * @return {boolean}
      */
     isErrorOrWarning: function()
     {
         return (this._message.level === WebInspector.ConsoleMessage.MessageLevel.Warning || this._message.level === WebInspector.ConsoleMessage.MessageLevel.Error);
     },
 
     _format: function(parameters)
     {
         // This node is used like a Builder. Values are continually appended onto it.
@@ skipping 736 matching lines @@
             if (!stackTrace)
                 return;
 
             for (var i = 0; i < stackTrace.length; i++) {
                 var frame = stackTrace[i];
 
                 var content = document.createElementWithClass("div", "stacktrace-entry");
                 var functionName = frame.functionName || WebInspector.UIString("(anonymous function)");
                 content.createChild("span", "console-message-text source-code").textContent = functionName;
 
-                if (frame.scriptId) {
+                if (frame.scriptId && this._linkifier) {
                     content.createTextChild(" ");
-                    var urlElement = this._linkifyCallFrame(frame);
-                    if (!urlElement)
-                        continue;
-                    content.appendChild(urlElement);
+                    content.appendChild(this._linkifier.linkifyConsoleCallFrame(this._target(), frame, "console-message-url"));
                 }
 
                 parentTreeElement.appendChild(new TreeElement(content));
             }
         }
 
         appendStackTrace.call(this, this._message.stackTrace);
 
         for (var asyncTrace = this._message.asyncStackTrace; asyncTrace; asyncTrace = asyncTrace.asyncStackTrace) {
             if (!asyncTrace.callFrames || !asyncTrace.callFrames.length)
@@ skipping 177 matching lines @@
     {
         if (!this._wrapperElement) {
             WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this);
             this._wrapperElement.classList.toggle("collapsed", this._collapsed);
         }
         return this._wrapperElement;
     },
 
     __proto__: WebInspector.ConsoleViewMessage.prototype
 }