Issue 448683002: Check for initialized code stub descriptor in the deoptimizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 448683002: Check for initialized code stub descriptor in the deoptimizer. (Closed)

Created:
6 years, 4 months ago by Yang

Modified:
6 years, 4 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Check for initialized code stub descriptor in the deoptimizer. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22932

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/deoptimizer.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

6 years, 4 months ago (2014-08-06 13:12:53 UTC) #2

LGTM with nit

https://codereview.chromium.org/448683002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/448683002/diff/1/src/deoptimizer.cc#newcode1629
src/deoptimizer.cc:1629: DCHECK(descriptor->MajorKey() == major_key);
DCHECK_EQ

Expand Messages | Collapse Messages