Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 448653003: Partially move history_types.{cc,h} to //components/history (Closed)

Created:
6 years, 4 months ago by sdefresne
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, browser-components-watch_chromium.org, pedrosimonetti+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Partially move history_types.{cc,h} to //components/history Move all types from //chrome/browser/history/history_types.{cc,h} that do not depends on content types to //components/history. BUG=371816 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -955 lines) Patch
M chrome/browser/history/history_backend.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/history/history_types.h View 6 chunks +1 line, -408 lines 0 comments Download
M chrome/browser/history/history_types.cc View 4 chunks +0 lines, -240 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/history/page_usage_data.h View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/history/page_usage_data.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/history/top_sites_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/visitsegment_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_page_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/history.gypi View 3 chunks +6 lines, -0 lines 0 comments Download
M components/history/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
A + components/history/core/browser/history_types.h View 8 chunks +3 lines, -132 lines 0 comments Download
A + components/history/core/browser/history_types.cc View 4 chunks +6 lines, -70 lines 0 comments Download
A + components/history/core/browser/page_usage_data.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/history/core/browser/page_usage_data.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sdefresne
Reland of https://codereview.chromium.org/439713004/ Some notes: 1. I don't think that using a width/height pair instead ...
6 years, 4 months ago (2014-08-06 13:07:48 UTC) #1
blundell
LGTM
6 years, 4 months ago (2014-08-06 13:16:20 UTC) #2
msw
On 2014/08/06 13:07:48, sdefresne wrote: > 1. I don't think that using a width/height pair ...
6 years, 4 months ago (2014-08-06 19:13:46 UTC) #3
brettw
LGTM rubberstamp
6 years, 4 months ago (2014-08-06 20:41:22 UTC) #4
sdefresne
On 2014/08/06 20:41:22, brettw wrote: > LGTM rubberstamp jhawkins: ping
6 years, 4 months ago (2014-08-08 16:31:29 UTC) #5
James Hawkins
lgtm
6 years, 4 months ago (2014-08-11 13:50:43 UTC) #6
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 4 months ago (2014-08-11 16:45:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/448653003/1
6 years, 4 months ago (2014-08-11 16:46:29 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-11 23:16:59 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 00:59:48 UTC) #10
Message was sent while issue was closed.
Change committed as 288852

Powered by Google App Engine
This is Rietveld 408576698