Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 448603002: Refactor unit tests for the base library to use GTest. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
CC:
v8-dev, tfarina
Project:
v8
Visibility:
Public.

Description

Refactor unit tests for the base library to use GTest. TEST=base-unittests BUG=v8:3489 LOG=y R=jochen@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22911

Patch Set 1 #

Patch Set 2 : Fix debugging leftover. #

Total comments: 4

Patch Set 3 : Reduce LoopIncrement test time. #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+883 lines, -1013 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + test/base-unittests/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A test/base-unittests/base-unittests.gyp View 1 chunk +32 lines, -0 lines 0 comments Download
A test/base-unittests/base-unittests.status View 1 chunk +6 lines, -0 lines 0 comments Download
A test/base-unittests/cpu-unittest.cc View 1 chunk +49 lines, -0 lines 1 comment Download
A test/base-unittests/platform/condition-variable-unittest.cc View 1 2 1 chunk +296 lines, -0 lines 2 comments Download
A test/base-unittests/platform/mutex-unittest.cc View 1 chunk +91 lines, -0 lines 0 comments Download
A test/base-unittests/platform/platform-unittest.cc View 1 chunk +115 lines, -0 lines 2 comments Download
A test/base-unittests/platform/time-unittest.cc View 1 chunk +183 lines, -0 lines 0 comments Download
A test/base-unittests/testcfg.py View 1 chunk +51 lines, -0 lines 0 comments Download
A test/base-unittests/utils/random-number-generator-unittest.cc View 1 chunk +53 lines, -0 lines 1 comment Download
M test/cctest/cctest.gyp View 7 chunks +0 lines, -13 lines 0 comments Download
D test/cctest/test-condition-variable.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D test/cctest/test-cpu.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D test/cctest/test-cpu-ia32.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D test/cctest/test-cpu-x64.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D test/cctest/test-cpu-x87.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D test/cctest/test-mutex.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M test/cctest/test-platform-linux.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D test/cctest/test-platform-macos.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D test/cctest/test-platform-tls.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M test/cctest/test-platform-win32.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/test-random-number-generator.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D test/cctest/test-time.cc View 1 chunk +0 lines, -198 lines 0 comments Download
M tools/presubmit.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M tools/run-tests.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Benedikt Meurer
As discussed earlier... PTAL
6 years, 4 months ago (2014-08-06 08:59:12 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/448603002/diff/20001/test/base-unittests/base-unittests.gyp File test/base-unittests/base-unittests.gyp (right): https://codereview.chromium.org/448603002/diff/20001/test/base-unittests/base-unittests.gyp#newcode12 test/base-unittests/base-unittests.gyp:12: 'target_name': 'base-unittests', nit. please use underscores
6 years, 4 months ago (2014-08-06 09:26:53 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/448603002/diff/20001/test/base-unittests/base-unittests.gyp File test/base-unittests/base-unittests.gyp (right): https://codereview.chromium.org/448603002/diff/20001/test/base-unittests/base-unittests.gyp#newcode12 test/base-unittests/base-unittests.gyp:12: 'target_name': 'base-unittests', On 2014/08/06 09:26:53, jochen wrote: > nit. ...
6 years, 4 months ago (2014-08-06 09:30:24 UTC) #3
Sven Panne
LGTM with a few tiny nits (although the stuff was already there before) https://codereview.chromium.org/448603002/diff/20001/test/base-unittests/cpu-unittest.cc File ...
6 years, 4 months ago (2014-08-06 09:33:28 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/448603002/diff/20001/test/base-unittests/cpu-unittest.cc File test/base-unittests/cpu-unittest.cc (right): https://codereview.chromium.org/448603002/diff/20001/test/base-unittests/cpu-unittest.cc#newcode34 test/base-unittests/cpu-unittest.cc:34: #if V8_HOST_ARCH_IA32 On 2014/08/06 09:33:28, Sven Panne wrote: > ...
6 years, 4 months ago (2014-08-06 09:35:06 UTC) #5
Benedikt Meurer
Committed patchset #3 manually as 22911 (presubmit successful).
6 years, 4 months ago (2014-08-06 09:35:36 UTC) #6
tfarina
6 years, 4 months ago (2014-08-11 15:22:27 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/448603002/diff/40001/test/base-unittests/cpu-...
File test/base-unittests/cpu-unittest.cc (right):

https://codereview.chromium.org/448603002/diff/40001/test/base-unittests/cpu-...
test/base-unittests/cpu-unittest.cc:5: #include "src/base/cpu.h"
do we need to separate this in a different directory?

In Chromium this would be src/base/cpu_unittest.cc, and Blink is also moving
torward this layout.

Powered by Google App Engine
This is Rietveld 408576698