Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 448593002: Make Gesture Tap be aware of Shadow DOM. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use useMockHighlight() Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/LinkHighlight.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 7f6775e22c3486d7aa8d72b3b8f70bf9e34103d0..293294707574d83cf3dc0e8d65924fa6feec3159 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -1049,7 +1049,7 @@ WebRect WebViewImpl::computeBlockBounds(const WebRect& rect, bool ignoreClipping
// Find the block type node based on the hit node.
while (node && (!node->renderer() || node->renderer()->isInline()))
- node = node->parentNode();
+ node = NodeRenderingTraversal::parent(node);
// Return the bounding box in the window coordinate system.
if (node) {
@@ -1173,7 +1173,7 @@ static Node* findCursorDefiningAncestor(Node* node, LocalFrame* frame)
if (cursor != CURSOR_AUTO || frame->eventHandler().useHandCursor(node, node->isLink()))
break;
}
- node = node->parentNode();
+ node = NodeRenderingTraversal::parent(node);
}
return node;
@@ -1204,7 +1204,7 @@ Node* WebViewImpl::bestTapNode(const PlatformGestureEvent& tapEvent)
// We might hit something like an image map that has no renderer on it
// Walk up the tree until we have a node with an attached renderer
while (bestTouchNode && !bestTouchNode->renderer())
- bestTouchNode = bestTouchNode->parentNode();
+ bestTouchNode = NodeRenderingTraversal::parent(bestTouchNode);
Node* cursorDefiningAncestor =
findCursorDefiningAncestor(bestTouchNode, m_page->deprecatedLocalMainFrame());
« no previous file with comments | « Source/web/LinkHighlight.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698