Make Gesture Tap be aware of Shadow DOM.

Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1035 matching lines @@
     IntPoint point = mainFrameImpl()->frameView()->windowToContents(IntPoint(rect.x, rect.y));
     HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active | (ignoreClipping ? HitTestRequest::IgnoreClipping : 0);
     HitTestResult result = mainFrameImpl()->frame()->eventHandler().hitTestResultAtPoint(point, hitType, IntSize(rect.width, rect.height));
 
     Node* node = result.innerNonSharedNode();
     if (!node)
         return WebRect();
 
     // Find the block type node based on the hit node.
     while (node && (!node->renderer() || node->renderer()->isInline()))
-        node = node->parentNode();
+        node = NodeRenderingTraversal::parent(node);
 
     // Return the bounding box in the window coordinate system.
     if (node) {
         IntRect rect = node->Node::pixelSnappedBoundingBox();
         LocalFrame* frame = node->document().frame();
         return frame->view()->contentsToWindow(rect);
     }
     return WebRect();
 }
 
@@ skipping 120 matching lines @@
 
     Node* bestTouchNode = 0;
 
     // FIXME: Rely on earlier hit test instead of hit testing again.
     GestureEventWithHitTestResults targetedEvent = m_page->deprecatedLocalMainFrame()->eventHandler().targetGestureEvent(tapEvent, true);
     bestTouchNode = targetedEvent.hitTestResult().targetNode();
 
     // We might hit something like an image map that has no renderer on it
     // Walk up the tree until we have a node with an attached renderer
     while (bestTouchNode && !bestTouchNode->renderer())
-        bestTouchNode = bestTouchNode->parentNode();
+        bestTouchNode = NodeRenderingTraversal::parent(bestTouchNode);

[esprehn, 2014/08/06 17:05:44]

What is updating the distribution before you call this in each of the places you
added this in this file?

[hayato, 2014/08/07 02:44:55]

I assumed distributions would be updated at the time of Hit tests.
I would make the HitTest have a responsibility of updating the distribution in
the next patch.

I think there is no side effect which affects distribution in this member
function.

I am feeling that we should have a well-established practice to make sure
distribution is surely updated before calling any functions which needs the
result of distributions.

 
     // Check if we're in the subtree of a node with a hand cursor
     // this is the heuristic we use to determine if we show a highlight on tap
     while (bestTouchNode && !invokesHandCursor(bestTouchNode, m_page->deprecatedLocalMainFrame()))
-        bestTouchNode = bestTouchNode->parentNode();
+        bestTouchNode = NodeRenderingTraversal::parent(bestTouchNode);
 
     if (!bestTouchNode)
         return 0;
 
     // We should pick the largest enclosing node with hand cursor set.
-    while (bestTouchNode->parentNode() && invokesHandCursor(bestTouchNode->parentNode(), toLocalFrame(m_page->mainFrame())))
-        bestTouchNode = bestTouchNode->parentNode();
-
+    Node* parentNode;
+    while ((parentNode = NodeRenderingTraversal::parent(bestTouchNode)) && invokesHandCursor(parentNode, toLocalFrame(m_page->mainFrame())))

[esprehn, 2014/08/06 17:05:44]

This would be nicer as a for loop and a break statement. the assignment inside
the while() is pretty confusing.

+        bestTouchNode = parentNode;
     return bestTouchNode;
 }
 
 void WebViewImpl::enableTapHighlightAtPoint(const PlatformGestureEvent& tapEvent)
 {
     Node* touchNode = bestTapNode(tapEvent);
 
     WillBeHeapVector<RawPtrWillBeMember<Node> > highlightNodes;
     highlightNodes.append(touchNode);
 
@@ skipping 3040 matching lines @@
     const PageScaleConstraints& constraints = m_pageScaleConstraintsSet.pageDefinedConstraints();
 
     if (!mainFrameImpl() || !mainFrameImpl()->frameView())
         return false;
 
     return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
         || (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);
 }
 
 } // namespace blink