Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 448563002: Revert 287689 "Add integration browser tests for settings harden..." (Closed)

Created:
6 years, 4 months ago by Adam Rice
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 287689 "Add integration browser tests for settings harden..." Broken official Windows builder: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/25818 > Add integration browser tests for settings hardening. > > This CL introduces the PrefHashBrowserTestBase fixture which these tests are based on. > > This fixture (in conjunction with the new PREF_HASH_BROWSER_TEST macro) provides an easy way to override 3 methods in order to: > 1) Setup Chrome as desired in a PRE_ test. > 2) Attack Preferences while Chrome isn't running. > 3) Relaunch Chrome and verify reaction to attacks. > > The fixture+macro also parametrizes every test such that they are ran in every SettingsEnforcement trial group. > > A few pieces were resurrected from the old PrefHashBrowserTest used to test unloaded profile seeding prior to http://crrev.com/277209 > > Review URL: https://codereview.chromium.org/431973002 TBR=gab@chromium.org,erikwright@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -778 lines) Patch
M trunk/src/chrome/browser/prefs/chrome_pref_service_factory.cc View 2 chunks +1 line, -4 lines 0 comments Download
D trunk/src/chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 1 chunk +0 lines, -773 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Adam Rice
6 years, 4 months ago (2014-08-06 07:01:56 UTC) #1
Adam Rice
6 years, 4 months ago (2014-08-06 07:02:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r287717 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698