Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 448543002: Allow installing paid apps from the launcher search results. (Closed)

Created:
6 years, 4 months ago by benwells
Modified:
6 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Allow installing paid apps from the launcher search results. Clicking on the install button for a paid app will now open the webstore page for the app, where the user can sign in (if not signed in already) and see the price of the app / buy it. BUG=319024 TEST=Check installing paid and unpaid apps from the app launcher search results. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289214

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Init variable #

Total comments: 4

Patch Set 4 : Feedback #

Patch Set 5 : Rebase #

Patch Set 6 : Fix tests #

Total comments: 2

Patch Set 7 : Um #

Patch Set 8 : partially clang format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M chrome/browser/ui/app_list/search/webstore/webstore_provider.cc View 1 2 6 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc View 1 2 3 4 5 6 7 4 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_result.h View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_result.cc View 1 2 3 4 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
benwells
6 years, 4 months ago (2014-08-06 08:05:30 UTC) #1
calamity
lgtm w/ nits. https://codereview.chromium.org/448543002/diff/40001/chrome/browser/ui/app_list/search/webstore/webstore_result.cc File chrome/browser/ui/app_list/search/webstore/webstore_result.cc (right): https://codereview.chromium.org/448543002/diff/40001/chrome/browser/ui/app_list/search/webstore/webstore_result.cc#newcode70 chrome/browser/ui/app_list/search/webstore/webstore_result.cc:70: const bool is_paid, And here. https://codereview.chromium.org/448543002/diff/40001/chrome/browser/ui/app_list/search/webstore/webstore_result.cc#newcode122 ...
6 years, 4 months ago (2014-08-11 04:20:10 UTC) #2
benwells
https://codereview.chromium.org/448543002/diff/40001/chrome/browser/ui/app_list/search/webstore/webstore_result.h File chrome/browser/ui/app_list/search/webstore/webstore_result.h (right): https://codereview.chromium.org/448543002/diff/40001/chrome/browser/ui/app_list/search/webstore/webstore_result.h#newcode37 chrome/browser/ui/app_list/search/webstore/webstore_result.h:37: const bool is_paid, On 2014/08/11 04:20:10, calamity wrote: > ...
6 years, 4 months ago (2014-08-11 07:11:56 UTC) #3
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 4 months ago (2014-08-11 07:12:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/448543002/60001
6 years, 4 months ago (2014-08-11 07:12:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-11 10:32:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 11:01:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/1709)
6 years, 4 months ago (2014-08-11 11:01:40 UTC) #8
benwells
calamity: I broke a test; latest patch set fixes it. Wanna have another look?
6 years, 4 months ago (2014-08-12 11:38:38 UTC) #9
calamity
SLGTM. https://codereview.chromium.org/448543002/diff/100001/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc File chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc (right): https://codereview.chromium.org/448543002/diff/100001/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc#newcode93 chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc:93: { "app3_id", "three", "http://host/icon3", false, nit: Is this ...
6 years, 4 months ago (2014-08-13 00:56:38 UTC) #10
benwells
https://codereview.chromium.org/448543002/diff/100001/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc File chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc (right): https://codereview.chromium.org/448543002/diff/100001/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc#newcode93 chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc:93: { "app3_id", "three", "http://host/icon3", false, On 2014/08/13 00:56:38, calamity ...
6 years, 4 months ago (2014-08-13 03:38:58 UTC) #11
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 4 months ago (2014-08-13 03:39:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/448543002/140001
6 years, 4 months ago (2014-08-13 03:40:28 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 08:29:15 UTC) #14
Message was sent while issue was closed. 
Change committed as 289214

Powered by Google App Engine
This is Rietveld 408576698