Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: Tools/GardeningServer/ui/ct-failure-analyzer.html

Issue 448503003: Adds a snooze button to the sheriff-o-matic ui (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unused import. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-failure-analyzer.html
diff --git a/Tools/GardeningServer/ui/ct-failure-analyzer.html b/Tools/GardeningServer/ui/ct-failure-analyzer.html
index f31bc4af8cf6c55f313cf59c22008843cefd860b..f634c7e1ca47791aaaeeabf507fbf7ddb0e072cb 100644
--- a/Tools/GardeningServer/ui/ct-failure-analyzer.html
+++ b/Tools/GardeningServer/ui/ct-failure-analyzer.html
@@ -5,6 +5,7 @@ found in the LICENSE file.
-->
<link rel="import" href="../model/ct-failure.html">
+<link rel="import" href="../model/ct-failure-group.html">
<polymer-element name="ct-failure-analyzer" attributes="failures builderLatestRevisions">
<script>
@@ -32,15 +33,18 @@ found in the LICENSE file.
},
update: function() {
+ var annotationPromise = CTFailureGroup.fetchAnnotations();
net.json('http://auto-sheriff.appspot.com/data').then(function(data) {
ojan 2014/08/07 00:09:58 This is good for now. FYI, I'm starting to think t
dstockwell 2014/08/11 01:20:42 Why does sheriff-o-matic need its own backend? Can
ojan 2014/08/11 01:44:43 Very shortly, in the next day or two, we'll be get
- // FIXME: Don't special-case the blink master.
- this.builderLatestRevisions = data.latest_revisions['chromium.webkit'];
- // FIXME: Make this a model class intead of a dumb object.
- this.failures = {};
- data.range_groups.forEach(function(group) {
- this._processFailuresForGroup(group, data.alerts);
+ annotationPromise.then(function(annotations) {
+ // FIXME: Don't special-case the blink master.
+ this.builderLatestRevisions = data.latest_revisions['chromium.webkit'];
+ // FIXME: Make this a model class intead of a dumb object.
+ this.failures = {};
+ data.range_groups.forEach(function(group) {
+ this._processFailuresForGroup(group, data.alerts, annotations);
+ }.bind(this));
+ // FIXME: Sort this.failures by severity of regression, then by oldestFailingRevision.
}.bind(this));
- // FIXME: Sort this.failures by severity of regression, then by oldestFailingRevision.
}.bind(this));
},
@@ -56,7 +60,7 @@ found in the LICENSE file.
return 0;
},
- _processFailuresForGroup: function(group, failures) {
+ _processFailuresForGroup: function(group, failures, annotations) {
var failuresByReason = {};
var masterToTree = {};
@@ -117,7 +121,9 @@ found in the LICENSE file.
if (!this.failures[tree])
this.failures[tree] = [];
- this.failures[tree].push(failures);
+ // FIXME: Need a better identifier for a failure group;
+ var key = group.sort_key;
+ this.failures[tree].push(new CTFailureGroup(key, failures, annotations[key]));
}.bind(this));
},
});

Powered by Google App Engine
This is Rietveld 408576698