Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1552)

Unified Diff: Tools/GardeningServer/ui/ct-failure-analyzer.html

Issue 448503003: Adds a snooze button to the sheriff-o-matic ui (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/test/unit-tests.html ('k') | Tools/GardeningServer/ui/ct-failure-card.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-failure-analyzer.html
diff --git a/Tools/GardeningServer/ui/ct-failure-analyzer.html b/Tools/GardeningServer/ui/ct-failure-analyzer.html
index fb6eb7f27b86a12687f70811ed9d9d5dbd4196ec..93d6980eb6659a7993c1c3781ba869c6cebc3269 100644
--- a/Tools/GardeningServer/ui/ct-failure-analyzer.html
+++ b/Tools/GardeningServer/ui/ct-failure-analyzer.html
@@ -6,6 +6,7 @@ found in the LICENSE file.
<link href="../model/ct-builder-revisions.html" rel="import">
<link rel="import" href="../model/ct-failure.html">
+<link rel="import" href="../model/ct-failure-group.html">
<polymer-element name="ct-failure-analyzer" attributes="failures builderLatestRevisions">
<script>
@@ -63,15 +64,18 @@ found in the LICENSE file.
},
update: function() {
+ var annotationPromise = CTFailureGroup.fetchAnnotations();
net.json('http://auto-sheriff.appspot.com/data').then(function(data) {
- // FIXME: Don't special-case the blink master.
- this.builderLatestRevisions = new CTBuilderRevisions(data.latest_revisions['chromium.webkit']);
- this.failures = {};
- data.range_groups.forEach(function(group) {
- this._processFailuresForGroup(group, data.alerts);
- }.bind(this));
- Object.keys(this.failures, function (tree, failuresByTree) {
- this.failures[tree].sort(this._failureListComparator.bind(this, tree));
+ annotationPromise.then(function(annotations) {
+ // FIXME: Don't special-case the blink master.
+ this.builderLatestRevisions = new CTBuilderRevisions(data.latest_revisions['chromium.webkit']);
+ this.failures = {};
+ data.range_groups.forEach(function(group) {
+ this._processFailuresForGroup(group, data.alerts, annotations);
+ }.bind(this));
+ Object.keys(this.failures, function (tree, failuresByTree) {
+ this.failures[tree].sort(this._failureListComparator.bind(this, tree));
+ }.bind(this));
}.bind(this));
}.bind(this));
},
@@ -88,7 +92,7 @@ found in the LICENSE file.
return 0;
},
- _processFailuresForGroup: function(group, failures) {
+ _processFailuresForGroup: function(group, failures, annotations) {
var failuresByReason = {};
var masterToTree = {};
@@ -150,7 +154,9 @@ found in the LICENSE file.
if (!this.failures[tree])
this.failures[tree] = [];
- this.failures[tree].push(failures);
+ // FIXME: Need a better identifier for a failure group;
+ var key = group.sort_key;
+ this.failures[tree].push(new CTFailureGroup(key, failures, annotations[key]));
}.bind(this));
},
});
« no previous file with comments | « Tools/GardeningServer/test/unit-tests.html ('k') | Tools/GardeningServer/ui/ct-failure-card.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698