Avoiding double resize of maximized windows upon user switch due to showing and hiding of the shelf

Avoiding double resize of maximized windows upon user switch due to showing and hiding of the shelf

BUG=385992
TEST=MultiUserWindowManagerChromeOSTest.TestBlackBarCover & visual inspection

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287880

[Mr4D (OOO till 08-26), 2014-08-05 23:46:32]

As discussed the solution for the double resize by adding a black rectangle on
top of the shelf instead of showing / hiding the shelf.

Since you asked for this you get the CL for review :)

Please have a look!

Note: The correct determination of shelf visibility changes for a new user is
highly complex (since distributed over various levels + might change since it is
behavioral look and feel). As such I kept the function to determine this state
"vague" on purpose. (e.g.: The Shelf gets shown if no window is there - in this
case the ash layer does not even know about that before switching users - or -
if a full screen usage case is active, the shelf would be hidden no matter what
and the ash layer does not know that a window of a different user is still full
screen or not, and so on).

[flackr, 2014-08-06 12:24:03]

LGTM

nit: specify the unit test MultiUserWindowManagerChromeOSTest.TestBlackBarCover
in TEST= and for visual probably give instruction like "Log in two users with
maximized windows and switch users. Shelf should hide behind black bar."

https://codereview.chromium.org/448493002/diff/1/chrome/browser/ui/ash/launch...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right):

https://codereview.chromium.org/448493002/diff/1/chrome/browser/ui/ash/launch...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:391: bool
ShelfVisibilityChangesProbablyWithUser(aura::Window* root_window,
How about s/Visibility/Bounds since no visibility implies empty bounds a bounds
change would seem to cover both location and visibility changes.

[Mr4D (OOO till 08-26), 2014-08-06 19:49:26]

Done. Thanks!

https://codereview.chromium.org/448493002/diff/1/chrome/browser/ui/ash/launch...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right):

https://codereview.chromium.org/448493002/diff/1/chrome/browser/ui/ash/launch...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:391: bool
ShelfVisibilityChangesProbablyWithUser(aura::Window* root_window,
On 2014/08/06 12:24:03, flackr wrote:
> How about s/Visibility/Bounds since no visibility implies empty bounds a
bounds
> change would seem to cover both location and visibility changes.

Done.

[Mr4D (OOO till 08-26), 2014-08-06 19:49:35]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-08-06 19:51:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skuhne@chromium.org/448493002/20001

[commit-bot: I haz the power, 2014-08-06 22:45:09]

Change committed as 287880