Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 448453002: Create struct in GrDrawState to hold key DrawState data. (Closed)

Created:
6 years, 4 months ago by egdaniel
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Create struct in GrDrawState to hold key DrawState data. Eventually this struct will be used to easily set values for a reduced, optimized drawstate BUG=skia: Committed: https://skia.googlesource.com/skia/+/776bdbde26217cc9afc2e83983ad863b8bb4d3b8

Patch Set 1 #

Patch Set 2 : some formatting fixes #

Patch Set 3 : Change name and add comment to struct #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -84 lines) Patch
M src/gpu/GrDrawState.h View 1 2 8 chunks +47 lines, -18 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 2 21 chunks +72 lines, -66 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
egdaniel
This is a reduced version of what I plan to fully do with GrDrawState. As ...
6 years, 4 months ago (2014-08-05 20:43:31 UTC) #1
bsalomon
I'm ok with this but I'd like a better name. I can't think of a ...
6 years, 4 months ago (2014-08-06 13:51:23 UTC) #2
egdaniel
6 years, 4 months ago (2014-08-06 15:02:09 UTC) #3
bsalomon
lgtm
6 years, 4 months ago (2014-08-06 15:15:23 UTC) #4
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 4 months ago (2014-08-06 15:31:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/448453002/40001
6 years, 4 months ago (2014-08-06 15:32:28 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 18:07:08 UTC) #7
Message was sent while issue was closed.
Change committed as 776bdbde26217cc9afc2e83983ad863b8bb4d3b8

Powered by Google App Engine
This is Rietveld 408576698