Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 448423002: Use a qualified path for grit includes in chrome/browser/chromeos. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
tfarina, Daniel Erat
CC:
chromium-reviews, yusukes+watch_chromium.org, yoshiki+watch_chromium.org, yukishiino+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, nona+watch_chromium.org, chromium-apps-reviews_chromium.org, derat+watch_chromium.org, tbarzic+watch_chromium.org, yuzo+watch_chromium.org, dkrahn+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, tfarina, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use a qualified path for grit includes in chrome/browser/chromeos. BUG=401588 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288512

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -108 lines) Patch
M chrome/browser/DEPS View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/app_mode/certificate_manager_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_launch_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/charger_replace/charger_link_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/charger_replace/charger_replacement_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/chromeos_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/enrollment_dialog_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_function_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/external_protocol_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/open_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/select_file_dialog_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/notification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/imageburner/burn_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/locale_change_guard.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/help_app_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_load_page.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_notification_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/options/cert_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/system/timezone_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/echo_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/idle_app_name_notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/idle_app_name_notification_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-08 01:19:10 UTC) #1
tfarina
https://codereview.chromium.org/448423002/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/448423002/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode47 chrome/browser/chromeos/accessibility/accessibility_manager.cc:47: #include "chrome/grit/generated_resources.h" I guess this works without gyp changes ...
6 years, 4 months ago (2014-08-08 01:23:04 UTC) #2
Lei Zhang
On 2014/08/08 01:23:04, tfarina wrote: > https://codereview.chromium.org/448423002/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc > File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): > > https://codereview.chromium.org/448423002/diff/1/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode47 > ...
6 years, 4 months ago (2014-08-08 01:31:06 UTC) #3
Daniel Erat
lgtm
6 years, 4 months ago (2014-08-08 15:00:26 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-08 18:36:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/448423002/1
6 years, 4 months ago (2014-08-08 18:37:16 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 20:25:14 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 20:37:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/2412)
6 years, 4 months ago (2014-08-08 20:37:37 UTC) #9
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-08 23:55:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/448423002/40001
6 years, 4 months ago (2014-08-08 23:56:40 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 05:36:18 UTC) #12
Message was sent while issue was closed. 
Change committed as 288512

Powered by Google App Engine
This is Rietveld 408576698