Issue 448403002: Set oem_manifest_loaded_ to true only after the manifest is actually loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 448403002: Set oem_manifest_loaded_ to true only after the manifest is actually loaded. (Closed)

Created:
6 years, 4 months ago by achuithb

Modified:
6 years, 4 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Set oem_manifest_loaded_ to true only after the manifest is actually loaded. Still seeing log spam because we set oem_manifest_loaded_ to true even if the file doesn't exist. Follow-up to r239700 BUG=314793 TEST=remove oem manifest.json - should not see spam in log file. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288423

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chromeos/system/statistics_provider.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/448403002/1

6 years, 4 months ago (2014-08-08 19:02:18 UTC) #4

Message was sent while issue was closed.

Change committed as 288423

Expand Messages | Collapse Messages