parameterize http response header tests

net/http/http_response_headers_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <limits>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/pickle.h"
@@ skipping 15 matching lines @@
 
 struct ContentTypeTestData {
   const std::string raw_headers;
   const std::string mime_type;
   const bool has_mimetype;
   const std::string charset;
   const bool has_charset;
   const std::string all_content_type;
 };
 
+struct MaxAgeTestData {
+    const char* max_age_string;
+    const int64 expected_seconds;
+};
+
 class HttpResponseHeadersTest : public testing::Test {
 };
 
 // Transform "normal"-looking headers (\n-separated) to the appropriate
 // input format for ParseRawHeaders (\0-separated).
 void HeadersToRaw(std::string* headers) {
   std::replace(headers->begin(), headers->end(), '\n', '\0');
   if (!headers->empty())
     *headers += '\0';
 }
@@ skipping 1973 matching lines @@
 
 TEST_F(HttpResponseHeadersCacheControlTest, MaxAgeCaseInsensitive) {
   InitializeHeadersWithCacheControl("Max-aGe=15");
   EXPECT_EQ(TimeDelta::FromSeconds(15), GetMaxAgeValue());
 }
 
 TEST_F(HttpResponseHeadersCacheControlTest, MaxAgeEdgeCases) {
   // This test doesn't use TEST_P() for consistency with the rest of the tests
   // in this file.
   // TODO(ricea): Port the tests in this file to use TEST_P().
-  const struct {
-    const char* max_age_string;
-    int64 expected_seconds;
-  } tests[] = {
+  const MaxAgeTestData tests[] = {

[Adam Rice, 2014/08/11 12:17:54]

It would probably be better to use ARRAYSIZE_UNSAFE in the loop for consistency
with the rest of the file.

[Mostyn Bramley-Moore, 2014/08/11 12:24:02]

I could try converting them all to use arraysize, which would you prefer?

[Adam Rice, 2014/08/11 12:28:46]

Unless you're willing to refactor all the tests to use TEST_P at the same time,
I don't think the disruption would be justified.

[Mostyn Bramley-Moore, 2014/08/11 12:35:36]

I will give that a try, but it might take a day or two until I have time.

         {" 1 ", 1},  // Spaces are ignored
         {"-1", -1},  // Negative numbers are passed through
         {"--1", 0},  // Leading junk gives 0
         {"2s", 2},  // trailing junk is ignored
         {"3 days", 3},
         {"'4'", 0},    // single quotes don't work
         {"\"5\"", 0},  // double quotes don't work
         {"0x6", 0},    // hex not parsed as hex
         {"7F", 7},     // hex without 0x still not parsed as hex
         {"010", 10},   // octal not parsed as octal
@@ skipping 35 matching lines @@
   InitializeHeadersWithCacheControl("max-age=3600,stale-while-revalidate=7200");
   EXPECT_EQ(TimeDelta::FromSeconds(7200), GetStaleWhileRevalidateValue());
 }
 
 TEST_F(HttpResponseHeadersCacheControlTest,
        FirstStaleWhileRevalidateValueUsed) {
   InitializeHeadersWithCacheControl(
       "stale-while-revalidate=1,stale-while-revalidate=7200");
   EXPECT_EQ(TimeDelta::FromSeconds(1), GetStaleWhileRevalidateValue());
 }