scripts/slave/recipe_modules/filter/example.py - Issue 448343002: Makes filter step continue on if error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/filter/example.py

Issue 448343002: Makes filter step continue on if error (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: --no-find-copies Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/filter/example.py

diff --git a/scripts/slave/recipe_modules/filter/example.py b/scripts/slave/recipe_modules/filter/example.py

index c1388a98c32a06ed6b91e649c030f861420b78d1..a8764b1a859c9ee50f08044d8b7bfae16106e0ad 100644

--- a/scripts/slave/recipe_modules/filter/example.py

+++ b/scripts/slave/recipe_modules/filter/example.py

@@ -76,3 +76,12 @@ def GenTests(api):

api.override_step_data(

'analyze',

api.json.output({'error': 'ERROR'})))

+ # Analyze with python returning bad status.

+ yield (api.test('bad_retcode_doesnt_fail') +

+ api.properties(matching_exes=None) +

+ api.properties(example_matching_exes=None) +

+ api.properties(example_result=1) +

+ api.step_data(

+ 'analyze',

+ retcode=-1))