Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 448313003: Land Recent QUIC Changes. (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar1, avd, Ian Swett, rjshade, wtc, jar (doing other things), Jana
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0807
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. A fix to QUIC's test only SendAlgorithmSimulator to ensure it treats lost packets correctly. Merge internal change: 72754445 https://codereview.chromium.org/450043002/ Check return value of GetStringPiece for (optional) kCCRT/kCCS in QuicCryptoServerConfig. Merge internal change: 72727018 https://codereview.chromium.org/453693002/ Store client cert hashes as strings instead of StringPieces. Avoids use-after-free (detected by ASAN) when the CHLO callback deletes the CHLO request, and subsequently we try to access the stored StringPieces. Bug introduced in CL: https://codereview.chromium.org/449273002/ Merge internal change: 72724874 https://codereview.chromium.org/453663002/ Deprecate rolled out flag: FLAGS_quic_allow_port_migration. Merge internal change: 72668120 https://codereview.chromium.org/451903002/ Along with sending the SCUP message, this CL includes small fixes which allow messages to be sent on the crypto stream after handshake has completed. This includes disabling HANDSHAKE_MODE in the sent packet manager after the handshake is confirmed, and stopping processing of handshake packets once we switch to forward secure and can no longer decrypt them in crypto_test_utils. Without a version bump, out of date clients will tear down the connection if they get a SCUP message from the server. QUIC_VERSION_22. Send a new source-address token when crypto handshake completes. Merge internal change: 72652054 https://codereview.chromium.org/449273002/ Trigger internal QUIC "trace graph" trace dumping also in cases where connection termination is initiated by the server. Protected by existing debug flag. This CL adds a new OnConnectionClosed method to the ConnectionDebugVisitor interface, which is called when the connection is closed irrespective of how the connection is closed. Merge internal change: 72571464 https://codereview.chromium.org/454563002/ Close a QUIC connection if there are too many unfinished streams being tracked in the locally closed map. Protected behind FLAGS_close_quic_connection_unfinished_streams (defaults to false). Merge internal change: 72561976 https://codereview.chromium.org/448973002/ Remove unused version argument from QuicFramerTest's GetMinStreamFrameSize. Merge internal change: 72559549 https://codereview.chromium.org/447103002/ Fix typo in comment in QuicFramer. creation_time_ is the creation time of the framer, not the frames. Comment only change. Merge internal change: 72558804 https://codereview.chromium.org/444323002/ Deprecate rolled out FLAGS_enable_quic_connection_flow_control_2. Merge internal change: 72345333 https://codereview.chromium.org/444313002/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -199 lines) Patch
M net/quic/congestion_control/send_algorithm_simulator.h View 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.cc View 7 chunks +10 lines, -11 lines 0 comments Download
M net/quic/crypto/crypto_handshake.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_handshake.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 3 chunks +9 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 4 chunks +55 lines, -10 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 3 chunks +40 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 3 chunks +52 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +7 lines, -1 line 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M net/quic/quic_dispatcher.h View 2 chunks +0 lines, -13 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 3 chunks +8 lines, -35 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +1 line, -6 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_framer_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.h View 4 chunks +6 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_session_test.cc View 8 chunks +29 lines, -14 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 4 chunks +2 lines, -10 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 2 chunks +0 lines, -13 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +1 line, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-08-08 00:28:48 UTC) #1
Ryan Hamilton
lgtm
6 years, 4 months ago (2014-08-08 03:48:12 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 4 months ago (2014-08-08 08:14:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/448313003/1
6 years, 4 months ago (2014-08-08 08:17:51 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 11:13:55 UTC) #5
Message was sent while issue was closed.
Change committed as 288331

Powered by Google App Engine
This is Rietveld 408576698