Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2945)

Unified Diff: cc/output/overlay_unittest.cc

Issue 448303002: Use custom ListContainer to allocate DrawQuads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@perftest
Patch Set: use at() for cc message unittest Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/overlay_unittest.cc
diff --git a/cc/output/overlay_unittest.cc b/cc/output/overlay_unittest.cc
index d805ae493ffce703c0ff512cc019e9d9897f2b57..71f1ddcf7d895dcb517a779db045149cff8f21d9 100644
--- a/cc/output/overlay_unittest.cc
+++ b/cc/output/overlay_unittest.cc
@@ -206,12 +206,13 @@ static void CompareRenderPassLists(const RenderPassList& expected_list,
actual->shared_quad_state_list.size());
EXPECT_EQ(expected->quad_list.size(), actual->quad_list.size());
- for (size_t i = 0; i < expected->quad_list.size(); ++i) {
- EXPECT_EQ(expected->quad_list[i]->rect.ToString(),
- actual->quad_list[i]->rect.ToString());
- EXPECT_EQ(
- expected->quad_list[i]->shared_quad_state->content_bounds.ToString(),
- actual->quad_list[i]->shared_quad_state->content_bounds.ToString());
+ for (QuadList::Iterator exp_iter = expected->quad_list.begin(),
+ act_iter = actual->quad_list.begin();
+ exp_iter != expected->quad_list.end();
+ ++exp_iter, ++act_iter) {
+ EXPECT_EQ(exp_iter->rect.ToString(), act_iter->rect.ToString());
+ EXPECT_EQ(exp_iter->shared_quad_state->content_bounds.ToString(),
+ act_iter->shared_quad_state->content_bounds.ToString());
}
}
}
@@ -308,7 +309,7 @@ TEST_F(SingleOverlayOnTopTest, SuccessfullOverlay) {
for (QuadList::ConstBackToFrontIterator it = quad_list.BackToFrontBegin();
it != quad_list.BackToFrontEnd();
++it) {
- EXPECT_NE(DrawQuad::TEXTURE_CONTENT, (*it)->material);
+ EXPECT_NE(DrawQuad::TEXTURE_CONTENT, it->material);
}
// Check that the right resource id got extracted.

Powered by Google App Engine
This is Rietveld 408576698