Use custom ListContainer to allocate DrawQuads

cc/layers/delegated_renderer_layer_impl_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/delegated_renderer_layer_impl.h"
 
 #include "cc/base/scoped_ptr_vector.h"
 #include "cc/layers/solid_color_layer_impl.h"
 #include "cc/quads/render_pass_draw_quad.h"
 #include "cc/quads/solid_color_draw_quad.h"
@@ skipping 171 matching lines @@
   // to the frame.
   EXPECT_EQ(4, frame.render_passes[1]->id.layer_id);
   EXPECT_EQ(1, frame.render_passes[1]->id.index);
   EXPECT_EQ(4, frame.render_passes[2]->id.layer_id);
   EXPECT_EQ(2, frame.render_passes[2]->id.index);
 
   // The DelegatedRendererLayer should have added copies of its quads to
   // contributing RenderPasses.
   ASSERT_EQ(1u, frame.render_passes[1]->quad_list.size());
   EXPECT_EQ(gfx::Rect(0, 0, 6, 6).ToString(),
-            frame.render_passes[1]->quad_list[0]->rect.ToString());
+            frame.render_passes[1]->quad_list.front()->rect.ToString());
 
   // Verify it added the right quads.
   ASSERT_EQ(2u, frame.render_passes[2]->quad_list.size());
-  EXPECT_EQ(gfx::Rect(0, 0, 7, 7).ToString(),
-            frame.render_passes[2]->quad_list[0]->rect.ToString());
-  EXPECT_EQ(gfx::Rect(6, 6, 6, 6).ToString(),
-            frame.render_passes[2]->quad_list[1]->rect.ToString());
+  QuadList::ConstIterator iter = frame.render_passes[2]->quad_list.begin();
+  EXPECT_EQ(gfx::Rect(0, 0, 7, 7).ToString(), iter->rect.ToString());
+  ++iter;
+  EXPECT_EQ(gfx::Rect(6, 6, 6, 6).ToString(), iter->rect.ToString());
   ASSERT_EQ(1u, frame.render_passes[1]->quad_list.size());
   EXPECT_EQ(gfx::Rect(0, 0, 6, 6).ToString(),
-            frame.render_passes[1]->quad_list[0]->rect.ToString());
+            frame.render_passes[1]->quad_list.front()->rect.ToString());
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestSimple, AddsQuadsToTargetRenderPass) {
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   // Each non-DelegatedRendererLayer added one RenderPass. The
   // DelegatedRendererLayer added two contributing passes.
   ASSERT_EQ(5u, frame.render_passes.size());
 
   // The layer's target is the RenderPass from layer_after_.
   EXPECT_EQ(RenderPassId(3, 0), frame.render_passes[3]->id);
 
   // The DelegatedRendererLayer should have added copies of quads in its root
   // RenderPass to its target RenderPass. The layer_after_ also adds one quad.
   ASSERT_EQ(2u, frame.render_passes[3]->quad_list.size());
 
+  QuadList::ConstIterator iter = frame.render_passes[3]->quad_list.begin();
   // Verify it added the right quads.
-  EXPECT_EQ(gfx::Rect(7, 7, 7, 7).ToString(),
-            frame.render_passes[3]->quad_list[0]->rect.ToString());
+  EXPECT_EQ(gfx::Rect(7, 7, 7, 7).ToString(), iter->rect.ToString());
 
+  ++iter;
   // Its target layer should have a quad as well.
-  EXPECT_EQ(gfx::Rect(0, 0, 15, 15).ToString(),
-            frame.render_passes[3]->quad_list[1]->rect.ToString());
+  EXPECT_EQ(gfx::Rect(0, 0, 15, 15).ToString(), iter->rect.ToString());
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestSimple,
        QuadsFromRootRenderPassAreModifiedForTheTarget) {
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   // Each non-DelegatedRendererLayer added one RenderPass. The
   // DelegatedRendererLayer added two contributing passes.
   ASSERT_EQ(5u, frame.render_passes.size());
 
   // The DelegatedRendererLayer is at position 3,3 compared to its target, and
   // has a translation transform of 1,1. So its root RenderPass' quads should
   // all be transformed by that combined amount.
   gfx::Transform transform;
   transform.Translate(4.0, 4.0);
   EXPECT_TRANSFORMATION_MATRIX_EQ(
-      transform, frame.render_passes[3]->quad_list[0]->quadTransform());
+      transform, frame.render_passes[3]->quad_list.front()->quadTransform());
 
   // Quads from non-root RenderPasses should not be shifted though.
   ASSERT_EQ(2u, frame.render_passes[2]->quad_list.size());
-  EXPECT_TRANSFORMATION_MATRIX_EQ(
-      gfx::Transform(), frame.render_passes[2]->quad_list[0]->quadTransform());
-  EXPECT_TRANSFORMATION_MATRIX_EQ(
-      gfx::Transform(), frame.render_passes[2]->quad_list[1]->quadTransform());
+
+  QuadList::ConstIterator iter = frame.render_passes[2]->quad_list.begin();
+  EXPECT_TRANSFORMATION_MATRIX_EQ(gfx::Transform(), iter->quadTransform());
+  ++iter;
+  EXPECT_TRANSFORMATION_MATRIX_EQ(gfx::Transform(), iter->quadTransform());
   ASSERT_EQ(1u, frame.render_passes[1]->quad_list.size());
   EXPECT_TRANSFORMATION_MATRIX_EQ(
-      gfx::Transform(), frame.render_passes[1]->quad_list[0]->quadTransform());
+      gfx::Transform(),
+      frame.render_passes[1]->quad_list.front()->quadTransform());
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestSimple, RenderPassTransformIsModified) {
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   // The delegated layer has a surface between it and the root.
@@ skipping 134 matching lines @@
   // to the frame.
   EXPECT_EQ(4, frame.render_passes[1]->id.layer_id);
   EXPECT_EQ(1, frame.render_passes[1]->id.index);
   EXPECT_EQ(4, frame.render_passes[2]->id.layer_id);
   EXPECT_EQ(2, frame.render_passes[2]->id.index);
 
   // The DelegatedRendererLayer should have added copies of its quads to
   // contributing RenderPasses.
   ASSERT_EQ(1u, frame.render_passes[1]->quad_list.size());
   EXPECT_EQ(gfx::Rect(0, 0, 6, 6).ToString(),
-            frame.render_passes[1]->quad_list[0]->rect.ToString());
+            frame.render_passes[1]->quad_list.front()->rect.ToString());
 
   // Verify it added the right quads.
   ASSERT_EQ(2u, frame.render_passes[2]->quad_list.size());
-  EXPECT_EQ(gfx::Rect(0, 0, 7, 7).ToString(),
-            frame.render_passes[2]->quad_list[0]->rect.ToString());
-  EXPECT_EQ(gfx::Rect(6, 6, 6, 6).ToString(),
-            frame.render_passes[2]->quad_list[1]->rect.ToString());
+
+  QuadList::ConstIterator iter = frame.render_passes[2]->quad_list.begin();
+  EXPECT_EQ(gfx::Rect(0, 0, 7, 7).ToString(), iter->rect.ToString());
+  ++iter;
+  EXPECT_EQ(gfx::Rect(6, 6, 6, 6).ToString(), iter->rect.ToString());
   ASSERT_EQ(1u, frame.render_passes[1]->quad_list.size());
   EXPECT_EQ(gfx::Rect(0, 0, 6, 6).ToString(),
-            frame.render_passes[1]->quad_list[0]->rect.ToString());
+            frame.render_passes[1]->quad_list.front()->rect.ToString());
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestOwnSurface, AddsQuadsToTargetRenderPass) {
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   // Each non-DelegatedRendererLayer added one RenderPass. The
   // DelegatedRendererLayer added two contributing passes and its owned surface
   // added one pass.
   ASSERT_EQ(6u, frame.render_passes.size());
 
   // The layer's target is the RenderPass owned by itself.
   EXPECT_EQ(RenderPassId(4, 0), frame.render_passes[3]->id);
 
   // The DelegatedRendererLayer should have added copies of quads in its root
   // RenderPass to its target RenderPass.
   // The layer_after also adds one quad.
   ASSERT_EQ(1u, frame.render_passes[3]->quad_list.size());
 
   // Verify it added the right quads.
   EXPECT_EQ(gfx::Rect(7, 7, 7, 7).ToString(),
-            frame.render_passes[3]->quad_list[0]->rect.ToString());
+            frame.render_passes[3]->quad_list.front()->rect.ToString());
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestOwnSurface,
        QuadsFromRootRenderPassAreNotModifiedForTheTarget) {
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   // Each non-DelegatedRendererLayer added one RenderPass. The
   // DelegatedRendererLayer added two contributing passes and its owned surface
   // added one pass.
   ASSERT_EQ(6u, frame.render_passes.size());
 
   // Because the DelegatedRendererLayer owns a RenderSurfaceImpl, its root
   // RenderPass' quads do not need to be translated at all.
   EXPECT_TRANSFORMATION_MATRIX_EQ(
-      gfx::Transform(), frame.render_passes[3]->quad_list[0]->quadTransform());
+      gfx::Transform(),
+      frame.render_passes[3]->quad_list.front()->quadTransform());
 
   // Quads from non-root RenderPasses should not be shifted either.
   ASSERT_EQ(2u, frame.render_passes[2]->quad_list.size());
-  EXPECT_TRANSFORMATION_MATRIX_EQ(
-      gfx::Transform(), frame.render_passes[2]->quad_list[0]->quadTransform());
-  EXPECT_TRANSFORMATION_MATRIX_EQ(
-      gfx::Transform(), frame.render_passes[2]->quad_list[1]->quadTransform());
+
+  QuadList::ConstIterator iter = frame.render_passes[2]->quad_list.begin();
+  EXPECT_TRANSFORMATION_MATRIX_EQ(gfx::Transform(), iter->quadTransform());

[danakj, 2014/09/23 17:59:38]

WDYT of adding ElementAt(size_t pos) to get at an element at an arbitrary
position in the structure so we don't have to iterate here? I think that'd help
a lot with readability of these test changes.

[weiliangc, 2014/09/24 20:14:35]

Add at(index) function as well as unittest.

+  ++iter;
+  EXPECT_TRANSFORMATION_MATRIX_EQ(gfx::Transform(), iter->quadTransform());
   ASSERT_EQ(1u, frame.render_passes[1]->quad_list.size());
   EXPECT_TRANSFORMATION_MATRIX_EQ(
-      gfx::Transform(), frame.render_passes[1]->quad_list[0]->quadTransform());
+      gfx::Transform(),
+      frame.render_passes[1]->quad_list.front()->quadTransform());
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 class DelegatedRendererLayerImplTestTransform
     : public DelegatedRendererLayerImplTest {
  public:
   DelegatedRendererLayerImplTestTransform()
       : root_delegated_render_pass_is_clipped_(false),
@@ skipping 152 matching lines @@
 
     const QuadList& contrib_delegated_quad_list =
         frame.render_passes[0]->quad_list;
     ASSERT_EQ(2u, contrib_delegated_quad_list.size());
 
     const QuadList& root_delegated_quad_list =
         frame.render_passes[1]->quad_list;
     ASSERT_EQ(5u, root_delegated_quad_list.size());
 
     // All quads in a render pass should share the same state.
-    *contrib_delegated_shared_quad_state =
-        contrib_delegated_quad_list[0]->shared_quad_state;
-    EXPECT_EQ(*contrib_delegated_shared_quad_state,
-              contrib_delegated_quad_list[1]->shared_quad_state);
+    QuadList::ConstIterator iter = contrib_delegated_quad_list.begin();
+    *contrib_delegated_shared_quad_state = iter->shared_quad_state;
+    ++iter;
+    EXPECT_EQ(*contrib_delegated_shared_quad_state, iter->shared_quad_state);
 
-    *root_delegated_shared_quad_state =
-        root_delegated_quad_list[0]->shared_quad_state;
-    EXPECT_EQ(*root_delegated_shared_quad_state,
-              root_delegated_quad_list[1]->shared_quad_state);
-    EXPECT_EQ(*root_delegated_shared_quad_state,
-              root_delegated_quad_list[2]->shared_quad_state);
-    EXPECT_EQ(*root_delegated_shared_quad_state,
-              root_delegated_quad_list[3]->shared_quad_state);
-    EXPECT_EQ(*root_delegated_shared_quad_state,
-              root_delegated_quad_list[4]->shared_quad_state);
+    iter = root_delegated_quad_list.begin();
+    *root_delegated_shared_quad_state = iter->shared_quad_state;
+    ++iter;
+    EXPECT_EQ(*root_delegated_shared_quad_state, iter->shared_quad_state);
+    ++iter;
+    EXPECT_EQ(*root_delegated_shared_quad_state, iter->shared_quad_state);
+    ++iter;
+    EXPECT_EQ(*root_delegated_shared_quad_state, iter->shared_quad_state);
+    ++iter;
+    EXPECT_EQ(*root_delegated_shared_quad_state, iter->shared_quad_state);
 
     EXPECT_NE(*contrib_delegated_shared_quad_state,
               *root_delegated_shared_quad_state);
   }
 
  protected:
   LayerImpl* root_layer_;
   DelegatedRendererLayerImpl* delegated_renderer_layer_;
   bool root_delegated_render_pass_is_clipped_;
   float delegated_device_scale_factor_;
@@ skipping 415 matching lines @@
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   ASSERT_EQ(2u, frame.render_passes.size());
   const QuadList& contrib_delegated_quad_list =
       frame.render_passes[0]->quad_list;
   ASSERT_EQ(2u, contrib_delegated_quad_list.size());
   const QuadList& root_delegated_quad_list = frame.render_passes[1]->quad_list;
   ASSERT_EQ(5u, root_delegated_quad_list.size());
   const SharedQuadState* root_delegated_shared_quad_state =
-      root_delegated_quad_list[0]->shared_quad_state;
+      root_delegated_quad_list.front()->shared_quad_state;
 
   // When the quads don't have a clip of their own, the clip rect is set to
   // the drawable_content_rect of the delegated renderer layer.
   EXPECT_EQ(gfx::Rect(20, 20, 50, 50).ToString(),
             root_delegated_shared_quad_state->clip_rect.ToString());
   // Quads are clipped to the delegated renderer layer.
   EXPECT_TRUE(root_delegated_shared_quad_state->is_clipped);
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestClip,
        QuadsClipped_LayerUnclipped_NoSurface) {
   root_delegated_render_pass_is_clipped_ = true;
   clip_delegated_renderer_layer_ = false;
   SetUpTest();
 
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   ASSERT_EQ(2u, frame.render_passes.size());
   const QuadList& contrib_delegated_quad_list =
       frame.render_passes[0]->quad_list;
   ASSERT_EQ(2u, contrib_delegated_quad_list.size());
   const QuadList& root_delegated_quad_list =
       frame.render_passes[1]->quad_list;
   ASSERT_EQ(5u, root_delegated_quad_list.size());
   const SharedQuadState* root_delegated_shared_quad_state =
-      root_delegated_quad_list[0]->shared_quad_state;
+      root_delegated_quad_list.front()->shared_quad_state;
 
   // When the quads have a clip of their own, it is used.
   EXPECT_EQ(gfx::Rect(25, 25, 40, 40).ToString(),
             root_delegated_shared_quad_state->clip_rect.ToString());
   // Quads came with a clip rect.
   EXPECT_TRUE(root_delegated_shared_quad_state->is_clipped);
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestClip,
        QuadsUnclipped_LayerClipped_NoSurface) {
   root_delegated_render_pass_is_clipped_ = false;
   clip_delegated_renderer_layer_ = true;
   SetUpTest();
 
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   ASSERT_EQ(2u, frame.render_passes.size());
   const QuadList& contrib_delegated_quad_list =
       frame.render_passes[0]->quad_list;
   ASSERT_EQ(2u, contrib_delegated_quad_list.size());
   const QuadList& root_delegated_quad_list = frame.render_passes[1]->quad_list;
   ASSERT_EQ(5u, root_delegated_quad_list.size());
   const SharedQuadState* root_delegated_shared_quad_state =
-      root_delegated_quad_list[0]->shared_quad_state;
+      root_delegated_quad_list.front()->shared_quad_state;
 
   // When the quads don't have a clip of their own, the clip rect is set to
   // the drawable_content_rect of the delegated renderer layer. When the layer
   // is clipped, that should be seen in the quads' clip_rect.
   EXPECT_EQ(gfx::Rect(21, 27, 23, 21).ToString(),
             root_delegated_shared_quad_state->clip_rect.ToString());
   // Quads are clipped to the delegated renderer layer.
   EXPECT_TRUE(root_delegated_shared_quad_state->is_clipped);
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestClip,
        QuadsClipped_LayerClipped_NoSurface) {
   root_delegated_render_pass_is_clipped_ = true;
   clip_delegated_renderer_layer_ = true;
   SetUpTest();
 
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   ASSERT_EQ(2u, frame.render_passes.size());
   const QuadList& contrib_delegated_quad_list =
       frame.render_passes[0]->quad_list;
   ASSERT_EQ(2u, contrib_delegated_quad_list.size());
   const QuadList& root_delegated_quad_list = frame.render_passes[1]->quad_list;
   ASSERT_EQ(5u, root_delegated_quad_list.size());
   const SharedQuadState* root_delegated_shared_quad_state =
-      root_delegated_quad_list[0]->shared_quad_state;
+      root_delegated_quad_list.front()->shared_quad_state;
 
   // When the quads have a clip of their own, it is used, but it is
   // combined with the clip rect of the delegated renderer layer.
   EXPECT_EQ(gfx::Rect(25, 27, 19, 21).ToString(),
             root_delegated_shared_quad_state->clip_rect.ToString());
   // Quads came with a clip rect.
   EXPECT_TRUE(root_delegated_shared_quad_state->is_clipped);
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
@@ skipping 10 matching lines @@
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   ASSERT_EQ(3u, frame.render_passes.size());
   const QuadList& contrib_delegated_quad_list =
       frame.render_passes[0]->quad_list;
   ASSERT_EQ(2u, contrib_delegated_quad_list.size());
   const QuadList& root_delegated_quad_list = frame.render_passes[1]->quad_list;
   ASSERT_EQ(5u, root_delegated_quad_list.size());
   const SharedQuadState* root_delegated_shared_quad_state =
-      root_delegated_quad_list[0]->shared_quad_state;
+      root_delegated_quad_list.front()->shared_quad_state;
 
   // When the layer owns a surface, the quads don't need to be clipped
   // further than they already specify. If they aren't clipped, then their
   // clip rect is ignored, and they are not set as clipped.
   EXPECT_FALSE(root_delegated_shared_quad_state->is_clipped);
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestClip,
        QuadsClipped_LayerUnclipped_Surface) {
   root_delegated_render_pass_is_clipped_ = true;
   clip_delegated_renderer_layer_ = false;
   SetUpTest();
 
   delegated_renderer_layer_->SetForceRenderSurface(true);
 
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   ASSERT_EQ(3u, frame.render_passes.size());
   const QuadList& contrib_delegated_quad_list =
       frame.render_passes[0]->quad_list;
   ASSERT_EQ(2u, contrib_delegated_quad_list.size());
   const QuadList& root_delegated_quad_list = frame.render_passes[1]->quad_list;
   ASSERT_EQ(5u, root_delegated_quad_list.size());
   const SharedQuadState* root_delegated_shared_quad_state =
-      root_delegated_quad_list[0]->shared_quad_state;
+      root_delegated_quad_list.front()->shared_quad_state;
 
   // When the quads have a clip of their own, it is used.
   EXPECT_EQ(gfx::Rect(5, 5, 40, 40).ToString(),
             root_delegated_shared_quad_state->clip_rect.ToString());
   // Quads came with a clip rect.
   EXPECT_TRUE(root_delegated_shared_quad_state->is_clipped);
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestClip,
        QuadsUnclipped_LayerClipped_Surface) {
   root_delegated_render_pass_is_clipped_ = false;
   clip_delegated_renderer_layer_ = true;
   SetUpTest();
 
   delegated_renderer_layer_->SetForceRenderSurface(true);
 
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   ASSERT_EQ(3u, frame.render_passes.size());
   const QuadList& contrib_delegated_quad_list =
       frame.render_passes[0]->quad_list;
   ASSERT_EQ(2u, contrib_delegated_quad_list.size());
   const QuadList& root_delegated_quad_list = frame.render_passes[1]->quad_list;
   ASSERT_EQ(5u, root_delegated_quad_list.size());
   const SharedQuadState* root_delegated_shared_quad_state =
-      root_delegated_quad_list[0]->shared_quad_state;
+      root_delegated_quad_list.front()->shared_quad_state;
 
   // When the layer owns a surface, the quads don't need to be clipped
   // further than they already specify. If they aren't clipped, then their
   // clip rect is ignored, and they are not set as clipped.
   EXPECT_FALSE(root_delegated_shared_quad_state->is_clipped);
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTestClip, QuadsClipped_LayerClipped_Surface) {
   root_delegated_render_pass_is_clipped_ = true;
   clip_delegated_renderer_layer_ = true;
   SetUpTest();
 
   delegated_renderer_layer_->SetForceRenderSurface(true);
 
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   ASSERT_EQ(3u, frame.render_passes.size());
   const QuadList& contrib_delegated_quad_list =
       frame.render_passes[0]->quad_list;
   ASSERT_EQ(2u, contrib_delegated_quad_list.size());
   const QuadList& root_delegated_quad_list = frame.render_passes[1]->quad_list;
   ASSERT_EQ(5u, root_delegated_quad_list.size());
   const SharedQuadState* root_delegated_shared_quad_state =
-      root_delegated_quad_list[0]->shared_quad_state;
+      root_delegated_quad_list.front()->shared_quad_state;
 
   // When the quads have a clip of their own, it is used, but it is
   // combined with the clip rect of the delegated renderer layer. If the
   // layer owns a surface, then it does not have a clip rect of its own.
   EXPECT_EQ(gfx::Rect(5, 5, 40, 40).ToString(),
             root_delegated_shared_quad_state->clip_rect.ToString());
   // Quads came with a clip rect.
   EXPECT_TRUE(root_delegated_shared_quad_state->is_clipped);
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
@@ skipping 39 matching lines @@
   root_layer->AddChild(delegated_renderer_layer.PassAs<LayerImpl>());
   host_impl_->active_tree()->SetRootLayer(root_layer.Pass());
 
   LayerTreeHostImpl::FrameData frame;
   EXPECT_EQ(DRAW_SUCCESS, host_impl_->PrepareToDraw(&frame));
 
   // The DelegatedRendererLayerImpl should drop the bad RenderPassDrawQuad.
   ASSERT_EQ(1u, frame.render_passes.size());
   ASSERT_EQ(1u, frame.render_passes[0]->quad_list.size());
   EXPECT_EQ(DrawQuad::SOLID_COLOR,
-            frame.render_passes[0]->quad_list[0]->material);
+            frame.render_passes[0]->quad_list.front()->material);
 
   host_impl_->DrawLayers(&frame, gfx::FrameTime::Now());
   host_impl_->DidDrawAllLayers(frame);
 }
 
 TEST_F(DelegatedRendererLayerImplTest, Occlusion) {
   gfx::Size layer_size(1000, 1000);
   gfx::Size viewport_size(1000, 1000);
   gfx::Rect quad_screen_rect(211, 300, 400, 500);
 
@@ skipping 36 matching lines @@
     SCOPED_TRACE("No occlusion");
     gfx::Rect occluded;
 
     {
       SCOPED_TRACE("Root render pass");
       impl.AppendQuadsForPassWithOcclusion(
           delegated_renderer_layer_impl, pass1_id, occluded);
       LayerTestCommon::VerifyQuadsExactlyCoverRect(impl.quad_list(),
                                                    quad_screen_rect);
       ASSERT_EQ(1u, impl.quad_list().size());
-      EXPECT_EQ(DrawQuad::RENDER_PASS, impl.quad_list()[0]->material);
+      EXPECT_EQ(DrawQuad::RENDER_PASS, impl.quad_list().front()->material);
     }
     {
       SCOPED_TRACE("Contributing render pass");
       impl.AppendQuadsForPassWithOcclusion(
           delegated_renderer_layer_impl, pass2_id, occluded);
       LayerTestCommon::VerifyQuadsExactlyCoverRect(
           impl.quad_list(), gfx::Rect(quad_screen_rect.size()));
       ASSERT_EQ(1u, impl.quad_list().size());
-      EXPECT_EQ(DrawQuad::SOLID_COLOR, impl.quad_list()[0]->material);
+      EXPECT_EQ(DrawQuad::SOLID_COLOR, impl.quad_list().front()->material);
     }
   }
 
   {
     SCOPED_TRACE("Full occlusion");
     {
       gfx::Rect occluded(delegated_renderer_layer_impl->visible_content_rect());
 
       SCOPED_TRACE("Root render pass");
       impl.AppendQuadsForPassWithOcclusion(
@@ skipping 44 matching lines @@
           impl.quad_list(),
           occlusion_in_target_of_delegated_quad,
           &partially_occluded_count);
       // The layer outputs one quad, which is partially occluded.
       EXPECT_EQ(1u, impl.quad_list().size());
       EXPECT_EQ(1u, partially_occluded_count);
       // The quad in the contributing surface is at (211,300) in the root.
       // The occlusion extends to 500 in the x-axis, pushing the left of the
       // visible part of the quad to 500 - 211 = 300 - 11 inside the quad.
       EXPECT_EQ(gfx::Rect(300 - 11, 0, 100 + 11, 500).ToString(),
-                impl.quad_list()[0]->visible_rect.ToString());
+                impl.quad_list().front()->visible_rect.ToString());
     }
     {
       gfx::Rect occlusion_in_root_target(0, 0, 500, 1000);
       // Move the occlusion to where it is in the contributing surface.
       gfx::Rect occlusion_in_target_of_delegated_quad =
           occlusion_in_root_target - quad_screen_rect.OffsetFromOrigin();
 
       SCOPED_TRACE("Contributing render pass with transformed root");
 
       gfx::Transform layer_transform;
@@ skipping 11 matching lines @@
           impl.quad_list(),
           occlusion_in_target_of_delegated_quad,
           &partially_occluded_count);
       // The layer outputs one quad, which is partially occluded.
       EXPECT_EQ(1u, impl.quad_list().size());
       EXPECT_EQ(1u, partially_occluded_count);
       // The quad in the contributing surface is at (222,300) in the transformed
       // root. The occlusion extends to 500 in the x-axis, pushing the left of
       // the visible part of the quad to 500 - 222 = 300 - 22 inside the quad.
       EXPECT_EQ(gfx::Rect(300 - 22, 0, 100 + 22, 500).ToString(),
-                impl.quad_list()[0]->visible_rect.ToString());
+                impl.quad_list().front()->visible_rect.ToString());
     }
   }
 }
 
 TEST_F(DelegatedRendererLayerImplTest, PushPropertiesTo) {
   gfx::Size layer_size(1000, 1000);
 
   scoped_ptr<FakeDelegatedRendererLayerImpl> delegated_renderer_layer_impl =
       FakeDelegatedRendererLayerImpl::Create(host_impl_->active_tree(), 5);
   delegated_renderer_layer_impl->SetBounds(layer_size);
@@ skipping 14 matching lines @@
   scoped_ptr<DelegatedRendererLayerImpl> other_layer =
       DelegatedRendererLayerImpl::Create(host_impl_->active_tree(), 6);
 
   delegated_renderer_layer_impl->PushPropertiesTo(other_layer.get());
 
   EXPECT_EQ(0.5f, other_layer->inverse_device_scale_factor());
 }
 
 }  // namespace
 }  // namespace cc