Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 448293002: This CL is a follow up to https://codereview.chromium.org/416683002/. (Closed)

Created:
6 years, 4 months ago by mshelley
Modified:
6 years, 4 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

This CL is a follow up to https://codereview.chromium.org/416683002/. It updates several comments and renames member variables to increase clarity and better match the style guide. R=wtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288282

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M net/socket/ssl_client_socket_openssl.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 11 chunks +34 lines, -33 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/socket/ssl_session_cache_openssl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_session_cache_openssl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/spawned_test_server/base_test_server.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mshelley
6 years, 4 months ago (2014-08-07 22:08:45 UTC) #1
wtc
Patch set 1 LGTM. https://codereview.chromium.org/448293002/diff/1/net/socket/ssl_client_socket_openssl.h File net/socket/ssl_client_socket_openssl.h (right): https://codereview.chromium.org/448293002/diff/1/net/socket/ssl_client_socket_openssl.h#newcode173 net/socket/ssl_client_socket_openssl.h:173: static void InfoCallback(const SSL* ssl, ...
6 years, 4 months ago (2014-08-07 23:25:31 UTC) #2
mshelley
The CQ bit was checked by mshelley@chromium.org
6 years, 4 months ago (2014-08-07 23:34:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mshelley@chromium.org/448293002/20001
6 years, 4 months ago (2014-08-08 00:01:18 UTC) #4
commit-bot: I haz the power
Change committed as 288282
6 years, 4 months ago (2014-08-08 09:39:39 UTC) #5
wtc
6 years, 4 months ago (2014-08-08 12:03:42 UTC) #6
Message was sent while issue was closed.
Patch set 2 LGTM.

Powered by Google App Engine
This is Rietveld 408576698