Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 448253002: Make the rotated rects bench allow more alpha/color variations and an arbitrary xfermode::mode. (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Make the rotated rects bench allow more alpha/color variations and an arbitrary xfermode::mode. Committed: https://skia.googlesource.com/skia/+/6563562cb6b03ad11e33b50b84acf43742b4477e

Patch Set 1 #

Patch Set 2 : correct upstream branch #

Patch Set 3 : Fix comment #

Total comments: 2

Patch Set 4 : Address comment and fix alt impl where first two rects were opaque #

Patch Set 5 : Fix missing #include and case warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -19 lines) Patch
M bench/RotatedRectBench.cpp View 1 2 3 4 4 chunks +120 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
bsalomon
6 years, 4 months ago (2014-08-07 20:00:56 UTC) #1
robertphillips
lgtm + nit https://codereview.chromium.org/448253002/diff/40001/bench/RotatedRectBench.cpp File bench/RotatedRectBench.cpp (right): https://codereview.chromium.org/448253002/diff/40001/bench/RotatedRectBench.cpp#newcode21 bench/RotatedRectBench.cpp:21: kChangingTransparent_ColorType, Fix opqaue typo ?
6 years, 4 months ago (2014-08-07 20:33:45 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-08-07 20:46:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/448253002/60001
6 years, 4 months ago (2014-08-07 20:48:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86_64-Release-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-08-07 21:51:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 21:53:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/860)
6 years, 4 months ago (2014-08-07 21:53:50 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-08-08 14:17:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/448253002/80001
6 years, 4 months ago (2014-08-08 14:18:54 UTC) #9
bsalomon
https://codereview.chromium.org/448253002/diff/40001/bench/RotatedRectBench.cpp File bench/RotatedRectBench.cpp (right): https://codereview.chromium.org/448253002/diff/40001/bench/RotatedRectBench.cpp#newcode21 bench/RotatedRectBench.cpp:21: kChangingTransparent_ColorType, On 2014/08/07 20:33:44, robertphillips wrote: > Fix opqaue ...
6 years, 4 months ago (2014-08-08 14:35:14 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 14:43:34 UTC) #11
Message was sent while issue was closed. 
Change committed as 6563562cb6b03ad11e33b50b84acf43742b4477e

Powered by Google App Engine
This is Rietveld 408576698