Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: extensions/common/manifest_handlers/icons_handler.cc

Issue 448193002: Cleanup: Make ExtensionIconSet::Get return a const std::string& rather than a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_icon_set.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_handlers/icons_handler.cc
diff --git a/extensions/common/manifest_handlers/icons_handler.cc b/extensions/common/manifest_handlers/icons_handler.cc
index 518ff4065272f5b6e8862c0c4f1651be203b98e4..c7e6c61e31974b138dce731ac6fdf7c4b53a971b 100644
--- a/extensions/common/manifest_handlers/icons_handler.cc
+++ b/extensions/common/manifest_handlers/icons_handler.cc
@@ -37,7 +37,7 @@ ExtensionResource IconsInfo::GetIconResource(
const Extension* extension,
int size,
ExtensionIconSet::MatchType match_type) {
- std::string path = GetIcons(extension).Get(size, match_type);
+ const std::string& path = GetIcons(extension).Get(size, match_type);
return path.empty() ? ExtensionResource() : extension->GetResource(path);
}
@@ -45,7 +45,7 @@ ExtensionResource IconsInfo::GetIconResource(
GURL IconsInfo::GetIconURL(const Extension* extension,
int size,
ExtensionIconSet::MatchType match_type) {
- std::string path = GetIcons(extension).Get(size, match_type);
+ const std::string& path = GetIcons(extension).Get(size, match_type);
return path.empty() ? GURL() : extension->GetResourceURL(path);
}
« no previous file with comments | « extensions/common/extension_icon_set.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698