Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/browser/extensions/sandboxed_unpacker.cc

Issue 448193002: Cleanup: Make ExtensionIconSet::Get return a const std::string& rather than a (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/extension_icon_image.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/sandboxed_unpacker.cc
diff --git a/chrome/browser/extensions/sandboxed_unpacker.cc b/chrome/browser/extensions/sandboxed_unpacker.cc
index d07eeeae757daf222561df418d323f91c6c2e908..f54c41d9ee4f280bc774d9bf383353c72bc6e28e 100644
--- a/chrome/browser/extensions/sandboxed_unpacker.cc
+++ b/chrome/browser/extensions/sandboxed_unpacker.cc
@@ -694,9 +694,8 @@ bool SandboxedUnpacker::RewriteImageFiles(SkBitmap* install_icon) {
}
}
- std::string install_icon_path = IconsInfo::GetIcons(extension_).Get(
- extension_misc::EXTENSION_ICON_LARGE,
- ExtensionIconSet::MATCH_BIGGER);
+ const std::string& install_icon_path = IconsInfo::GetIcons(extension_).Get(
+ extension_misc::EXTENSION_ICON_LARGE, ExtensionIconSet::MATCH_BIGGER);
// Write our parsed images back to disk as well.
for (size_t i = 0; i < images.size(); ++i) {
« no previous file with comments | « no previous file | extensions/browser/extension_icon_image.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698