Support for providing media stream audio track to speech recognition

Source/modules/speech/SpeechRecognition.cpp

Index: Source/modules/speech/SpeechRecognition.cpp
diff --git a/Source/modules/speech/SpeechRecognition.cpp b/Source/modules/speech/SpeechRecognition.cpp
index a598db638a48d539d0cff0c859230301cf86d8f3..7eaa9a5c2c10497fd2a4296c73e1410c4c65516e 100644
--- a/Source/modules/speech/SpeechRecognition.cpp
+++ b/Source/modules/speech/SpeechRecognition.cpp
@@ -53,6 +53,7 @@ void SpeechRecognition::start(ExceptionState& exceptionState)
     }
 
     m_finalResults.clear();
+    m_controller->attach(this, m_audioTrack);
     m_controller->start(this, m_grammars.get(), m_lang, m_continuous, m_interimResults, m_maxAlternatives);

[no longer working on chromium, 2014/08/15 10:22:56]

I am wondering if we should just pass the m_audioTrack in the start method. Lets
get Glen's opinion on this.

[burnik, 2014/08/15 11:29:41]

I've gone through that approach as well, and in order to follow the same path as
rest of the params, we would have to add the audio track to
WebSpeechRecognitionParams. That looks a bit messy and out of place to me. I
think it's cleaner this way since the audio track is an extension to existing
behaviour and all other params are API related, while m_audioTrack is not.

However, I do agree, Glen should help us decide.

On 2014/08/15 10:22:56, xians1 wrote:

     m_started = true;
 }
@@ -168,6 +169,7 @@ bool SpeechRecognition::hasPendingActivity() const
 SpeechRecognition::SpeechRecognition(ExecutionContext* context)
     : ActiveDOMObject(context)
     , m_grammars(SpeechGrammarList::create()) // FIXME: The spec is not clear on the default value for the grammars attribute.
+    , m_audioTrack(nullptr)
     , m_continuous(false)
     , m_interimResults(false)
     , m_maxAlternatives(1)
@@ -195,6 +197,7 @@ SpeechRecognition::~SpeechRecognition()
 void SpeechRecognition::trace(Visitor* visitor)
 {
     visitor->trace(m_grammars);
+    visitor->trace(m_audioTrack);
 #if ENABLE(OILPAN)
     visitor->trace(m_controller);
 #endif