Support for providing media stream audio track to speech recognition

Source/web/SpeechRecognitionClientProxy.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 15 matching lines @@
 #include "config.h"
 #include "web/SpeechRecognitionClientProxy.h"
 
 #include "core/dom/ExecutionContext.h"
 #include "modules/speech/SpeechGrammarList.h"
 #include "modules/speech/SpeechRecognition.h"
 #include "modules/speech/SpeechRecognitionError.h"
 #include "modules/speech/SpeechRecognitionResult.h"
 #include "modules/speech/SpeechRecognitionResultList.h"
 #include "platform/weborigin/SecurityOrigin.h"
+#include "public/platform/WebMediaStreamTrack.h"
 #include "public/web/WebSecurityOrigin.h"
 #include "public/web/WebSpeechGrammar.h"
 #include "public/web/WebSpeechRecognitionHandle.h"
 #include "public/web/WebSpeechRecognitionParams.h"
 #include "public/web/WebSpeechRecognitionResult.h"
 #include "public/web/WebSpeechRecognizer.h"
 #include "wtf/PassRefPtr.h"
 
 namespace blink {
 
 SpeechRecognitionClientProxy::~SpeechRecognitionClientProxy()
 {
 }
 
 PassOwnPtr<SpeechRecognitionClientProxy> SpeechRecognitionClientProxy::create(WebSpeechRecognizer* recognizer)
 {
     return adoptPtr(new SpeechRecognitionClientProxy(recognizer));
 }
 
+void SpeechRecognitionClientProxy::setAudioTrack(SpeechRecognition* recognition, MediaStreamTrack* audioTrack)
+{
+    m_recognizer->setAudioTrack(WebSpeechRecognitionHandle(recognition), audioTrack->component(), this);

[no longer working on chromium, 2014/08/14 15:41:34]

how about
if (audioTrack) {
   m_recognizer->Attach(WebSpeechRecognitionHandle(recognition), audioTr
     ack->component(), this);
} else {
   m_recognizer->Detach(WebSpeechRecognitionHandle(recognition), this);
}
  

[burnik, 2014/08/14 16:35:15]

I wonder if it's a good design to introduce logic on the proxy - maybe this
should reside on the |SpeechRecognition|.

On 2014/08/14 15:41:34, xians1 wrote:

+}
+
+void SpeechRecognitionClientProxy::clearAudioTrack(SpeechRecognition* recognition)
+{
+    m_recognizer->clearAudioTrack(WebSpeechRecognitionHandle(recognition), this);
+}
+
 void SpeechRecognitionClientProxy::start(SpeechRecognition* recognition, const SpeechGrammarList* grammarList, const String& lang, bool continuous, bool interimResults, unsigned long maxAlternatives)
 {
     WebVector<WebSpeechGrammar> webSpeechGrammars(static_cast<size_t>(grammarList->length()));
     for (unsigned long i = 0; i < grammarList->length(); ++i)
         webSpeechGrammars[i] = grammarList->item(i);
 
     WebSpeechRecognitionParams params(webSpeechGrammars, lang, continuous, interimResults, maxAlternatives, WebSecurityOrigin(recognition->executionContext()->securityOrigin()));
     m_recognizer->start(WebSpeechRecognitionHandle(recognition), params, this);
 }
 
@@ skipping 72 matching lines @@
     SpeechRecognition* recognition(handle);
     recognition->didEnd();
 }
 
 SpeechRecognitionClientProxy::SpeechRecognitionClientProxy(WebSpeechRecognizer* recognizer)
     : m_recognizer(recognizer)
 {
 }
 
 } // namespace blink