Support for providing media stream audio track to speech recognition

Source/modules/speech/SpeechRecognitionController.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT OWNER OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef SpeechRecognitionController_h
 #define SpeechRecognitionController_h
 
 #include "core/page/Page.h"
+#include "modules/mediastream/MediaStreamTrack.h"
 #include "modules/speech/SpeechRecognitionClient.h"
 #include "wtf/PassOwnPtr.h"
 
 namespace blink {
 
 class SpeechRecognitionController FINAL : public NoBaseWillBeGarbageCollectedFinalized<SpeechRecognitionController>, public WillBeHeapSupplement<Page> {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SpeechRecognitionController);
 public:
     virtual ~SpeechRecognitionController();
 
-    void start(SpeechRecognition* recognition, const SpeechGrammarList* grammars, const String& lang, bool continuous, bool interimResults, unsigned long maxAlternatives)
+    void start(SpeechRecognition* recognition, const SpeechGrammarList* grammars, const String& lang, bool continuous, bool interimResults, unsigned long maxAlternatives, MediaStreamTrack* audioTrack)

[Mike West, 2014/09/17 10:20:27]

Hrm. The various '::start()' methods are getting a bit unwieldy. Perhaps it
would make sense to create an initialization object (struct) that you could pass
in here, rather than relying on memory and the compiler's type checking to
ensure that everything is passed in and piped through in the right order?

[burnik, 2014/09/17 11:17:20]

Could you take a look at the previous patchset? I've added attach/detach which
at least partially avoids this.

Controller and Client just pass thru data. No real logic until reaching to the
public web interface.

On 2014/09/17 10:20:27, Mike West wrote:

[Mike West, 2014/09/17 11:30:46]

I like this approach more than the separate attach/detach steps. This seems like
the right direction to go, the argument list just seems to be getting pretty
long. I certainly won't insist on refactoring all the calls to ::start in this
CL, but I do think it's worth moving to a one-parameter model in the future to
keep things simple.
Yup. My claim is simply that bringing those parameters out into a separate
object a) makes it clear exactly what bits and pieces are required, and b) makes
it simpler to understand what needs to be passed around in order to kick off
recognition.

     {
-        m_client->start(recognition, grammars, lang, continuous, interimResults, maxAlternatives);
+        m_client->start(recognition, grammars, lang, continuous, interimResults, maxAlternatives, audioTrack);
     }
 
     void stop(SpeechRecognition* recognition) { m_client->stop(recognition); }
     void abort(SpeechRecognition* recognition) { m_client->abort(recognition); }
 
     static PassOwnPtrWillBeRawPtr<SpeechRecognitionController> create(PassOwnPtr<SpeechRecognitionClient>);
     static const char* supplementName();
     static SpeechRecognitionController* from(Page* page) { return static_cast<SpeechRecognitionController*>(WillBeHeapSupplement<Page>::from(page, supplementName())); }
 
     virtual void trace(Visitor* visitor) OVERRIDE { WillBeHeapSupplement<Page>::trace(visitor); }
 
 private:
     explicit SpeechRecognitionController(PassOwnPtr<SpeechRecognitionClient>);
 
     OwnPtr<SpeechRecognitionClient> m_client;
 };
 
 } // namespace blink
 
 #endif // SpeechRecognitionController_h