Support for providing media stream audio track to speech recognition

Source/modules/speech/SpeechRecognition.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 10 matching lines @@
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef SpeechRecognition_h
 #define SpeechRecognition_h
 
 #include "core/dom/ActiveDOMObject.h"
 #include "modules/EventTargetModules.h"
+#include "modules/mediastream/MediaStreamTrack.h"

[Mike West, 2014/09/17 10:20:27]

I think you can forward-declare this here, and only pull the header in  when you
access MediaStreamTrack methods in SpeechRecognitionClient.cpp.

[burnik, 2014/09/17 11:17:20]

Yes, actually in SpeechRecognitionClientProxy.cpp where I first access the
members.
Done.
On 2014/09/17 10:20:27, Mike West wrote:

 #include "modules/speech/SpeechGrammarList.h"
 #include "modules/speech/SpeechRecognitionResult.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Compiler.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 class ExceptionState;
 class ExecutionContext;
 class SpeechRecognitionController;
 class SpeechRecognitionError;
 
 class SpeechRecognition FINAL : public RefCountedGarbageCollectedWillBeGarbageCollectedFinalized<SpeechRecognition>, public ActiveDOMObject, public EventTargetWithInlineData {
     DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(RefCountedGarbageCollected<SpeechRecognition>);
     DEFINE_WRAPPERTYPEINFO();
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SpeechRecognition);
 public:
     static SpeechRecognition* create(ExecutionContext*);
     virtual ~SpeechRecognition();
 
     // Attributes.

[Mike West, 2014/09/17 10:20:27]

Nit: Can you change this to note that these are publicly exposed via the IDL
file? Perhaps '// SpeechRecognition.idl implementation:'.

[burnik, 2014/09/17 11:17:20]

Not a bad idea. Although this affects other parts as well - not just attributes.
Added a comment above this line.
On 2014/09/17 10:20:27, Mike West wrote:

     SpeechGrammarList* grammars() { return m_grammars; }
     void setGrammars(SpeechGrammarList* grammars) { m_grammars = grammars; }
     String lang() { return m_lang; }
     void setLang(const String& lang) { m_lang = lang; }
     bool continuous() { return m_continuous; }
     void setContinuous(bool continuous) { m_continuous = continuous; }
     bool interimResults() { return m_interimResults; }
     void setInterimResults(bool interimResults) { m_interimResults = interimResults; }
     unsigned long maxAlternatives() { return m_maxAlternatives; }
     void setMaxAlternatives(unsigned long maxAlternatives) { m_maxAlternatives = maxAlternatives; }
+    MediaStreamTrack* audioTrack() { return m_audioTrack; }
+    void setAudioTrack(MediaStreamTrack* audioTrack) { m_audioTrack = audioTrack; }
 
     // Callable by the user.
     void start(ExceptionState&);
     void stopFunction();
     void abort();
 
     // Called by the SpeechRecognitionClient.
     void didStartAudio();
     void didStartSound();
     void didStartSpeech();
@@ skipping 25 matching lines @@
     DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(start);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(end);
 
     virtual void trace(Visitor*) OVERRIDE;
 
 private:
     explicit SpeechRecognition(ExecutionContext*);
 
     Member<SpeechGrammarList> m_grammars;
+    Member<MediaStreamTrack> m_audioTrack;
     String m_lang;
     bool m_continuous;
     bool m_interimResults;
     unsigned long m_maxAlternatives;
 
     RawPtrWillBeMember<SpeechRecognitionController> m_controller;
     bool m_stoppedByActiveDOMObject;
     bool m_started;
     bool m_stopping;
     HeapVector<Member<SpeechRecognitionResult> > m_finalResults;
 };
 
 } // namespace blink
 
 #endif // SpeechRecognition_h