Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 448163002: Simplify overridable logic in SSLBlockingPage (Closed)

Created:
6 years, 4 months ago by felt
Modified:
6 years, 4 months ago
Reviewers:
palmer
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Simplify overridable logic in SSLBlockingPage Right now, SSLBlockingPage has both overridable_ and strict_enforcement_. This CL collapses both into overridable_, so that we only need to check one. However, strict_enforcement_ also remains on its own because it is checked separately in one place. BUG= R=palmer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/ssl/ssl_blocking_page.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 7 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
felt
palmer: pls review.
6 years, 4 months ago (2014-08-07 14:41:03 UTC) #1
palmer
lgtm
6 years, 4 months ago (2014-08-07 19:04:55 UTC) #2
felt
The CQ bit was checked by felt@chromium.org
6 years, 4 months ago (2014-08-07 19:06:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/448163002/1
6 years, 4 months ago (2014-08-07 19:11:59 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 22:42:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 23:44:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3457)
6 years, 4 months ago (2014-08-07 23:44:27 UTC) #7
felt
The CQ bit was checked by felt@chromium.org
6 years, 4 months ago (2014-08-08 22:45:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/448163002/1
6 years, 4 months ago (2014-08-08 22:46:52 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 22:52:33 UTC) #10
Message was sent while issue was closed.
Change committed as 288456

Powered by Google App Engine
This is Rietveld 408576698