Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 448153002: BT adapter is switched to initial state after HID screen if no BT devices connected. (Closed)

Created:
6 years, 4 months ago by merkulova
Modified:
6 years, 4 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

BT adapter is switched to initial state after HID screen if no BT devices connected. BUG=401501 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288079

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc View 1 5 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
merkulova
Version without taking into account user-made BT state changes.
6 years, 4 months ago (2014-08-07 14:14:41 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/448153002/diff/1/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc (right): https://codereview.chromium.org/448153002/diff/1/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc#newcode211 chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc:211: adapter_initially_powered_ && !(*adapter_initially_powered_.get())) { nit: you don't need ...
6 years, 4 months ago (2014-08-07 14:47:29 UTC) #2
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 4 months ago (2014-08-07 14:58:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/448153002/20001
6 years, 4 months ago (2014-08-07 14:59:37 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 16:41:37 UTC) #5
Message was sent while issue was closed.
Change committed as 288079

Powered by Google App Engine
This is Rietveld 408576698