components/url_fixer/url_fixer.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/url_fixer/url_fixer.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/local_discovery/device_description.cc ('K') | « components/translate/core/language_detection/language_detection_util.cc ('k') | content/browser/accessibility/browser_accessibility.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/url_fixer/url_fixer.cc

diff --git a/components/url_fixer/url_fixer.cc b/components/url_fixer/url_fixer.cc

index 5b90cd203e1ee17be52aa73222999926687d24e6..a63ed547baf4a4780d4ba8bb58ddfd1a3b4a803f 100644

--- a/components/url_fixer/url_fixer.cc

+++ b/components/url_fixer/url_fixer.cc

@@ -538,7 +538,7 @@ GURL url_fixer::FixupURL(const std::string& text,

// Parse and rebuild about: and chrome: URLs, except about:blank.

bool chrome_url =

- !LowerCaseEqualsASCII(trimmed, url::kAboutBlankURL) &&

+ !base::LowerCaseEqualsASCII(trimmed, url::kAboutBlankURL) &&

((scheme == url::kAboutScheme) || (scheme == kChromeUIScheme));

// For some schemes whose layouts we understand, we rebuild it.