components/data_reduction_proxy/common/data_reduction_proxy_headers.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/local_discovery/device_description.cc ('K') | « components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc ('k') | components/dom_distiller/core/viewer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

diff --git a/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc b/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

index d97c35c52220fba7088e337880d3d7635b9d7802..fc67c146ca6f7be5d39b901807e5e01cf94ca9eb 100644

--- a/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

+++ b/components/data_reduction_proxy/common/data_reduction_proxy_headers.cc

@@ -44,9 +44,9 @@ bool ParseHeadersAndSetBypassDuration(const net::HttpResponseHeaders* headers,

while (headers->EnumerateHeader(&iter, name, &value)) {

if (value.size() > action_prefix.size()) {

- if (LowerCaseEqualsASCII(value.begin(),

- value.begin() + action_prefix.size(),

- action_prefix.c_str())) {

+ if (base::LowerCaseEqualsASCII(value.begin(),

+ value.begin() + action_prefix.size(),

+ action_prefix.c_str())) {

int64 seconds;

if (!base::StringToInt64(

StringPiece(value.begin() + action_prefix.size(), value.end()),