chrome/renderer/web_apps.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/web_apps.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/local_discovery/device_description.cc ('K') | « chrome/renderer/translate/translate_helper.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/web_apps.cc

diff --git a/chrome/renderer/web_apps.cc b/chrome/renderer/web_apps.cc

index 736015b46284cd3b748aff076faacb3c4d025002..ea4e0b3eecf45bd96034ae79c2e80b2aa8d3b3fa 100644

--- a/chrome/renderer/web_apps.cc

+++ b/chrome/renderer/web_apps.cc

@@ -149,12 +149,13 @@ bool ParseWebAppFromWebDocument(WebFrame* frame,

// Streamlined Hosted Apps also support "apple-touch-icon" and

// "apple-touch-icon-precomposed".

- if (LowerCaseEqualsASCII(rel, "icon") ||

- LowerCaseEqualsASCII(rel, "shortcut icon") ||

+ if (base::LowerCaseEqualsASCII(rel, "icon") ||

+ base::LowerCaseEqualsASCII(rel, "shortcut icon") ||

(CommandLine::ForCurrentProcess()->

HasSwitch(switches::kEnableStreamlinedHostedApps) &&

- (LowerCaseEqualsASCII(rel, "apple-touch-icon") ||

- LowerCaseEqualsASCII(rel, "apple-touch-icon-precomposed")))) {

+ (base::LowerCaseEqualsASCII(rel, "apple-touch-icon") ||

+ base::LowerCaseEqualsASCII(rel,

+ "apple-touch-icon-precomposed")))) {

AddInstallIcon(elem, &app_info->icons);

}

} else if (elem.hasHTMLTagName("meta") && elem.hasAttribute("name")) {