chrome/browser/io_thread.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/io_thread.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/visitsegment_database.cc ('k') | chrome/browser/local_discovery/device_description.cc » ('j') | chrome/browser/local_discovery/device_description.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/io_thread.cc

diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc

index 82bfdac9080db8b1d13e48cf2a85c94373c0a8b8..de1d2cb9024067d0f99149056a706c1e56211208 100644

--- a/chrome/browser/io_thread.cc

+++ b/chrome/browser/io_thread.cc

@@ -1245,9 +1245,9 @@ bool IOThread::ShouldEnableQuicPacing(

if (command_line.HasSwitch(switches::kDisableQuicPacing))

return false;

- if (LowerCaseEqualsASCII(

- GetVariationParam(quic_trial_params, "enable_pacing"),

- "true"))

+ if (base::LowerCaseEqualsASCII(

+ GetVariationParam(quic_trial_params, "enable_pacing"),

+ "true"))

return true;

return quic_trial_group.ends_with(kQuicFieldTrialPacingSuffix);

@@ -1323,9 +1323,10 @@ bool IOThread::ShouldEnableQuicTimeBasedLossDetection(

if (command_line.HasSwitch(switches::kDisableQuicTimeBasedLossDetection))

return false;

- if (LowerCaseEqualsASCII(

- GetVariationParam(quic_trial_params, "enable_time_based_loss_detection"),

- "true"))

+ if (base::LowerCaseEqualsASCII(

+ GetVariationParam(quic_trial_params,

+ "enable_time_based_loss_detection"),

+ "true"))

return true;

return quic_trial_group.ends_with(