chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter.cc ('k') | chrome/browser/chromeos/input_method/input_method_util.cc » ('j') | chrome/browser/local_discovery/device_description.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

diff --git a/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc b/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

index 780e8837c225468666559ce38e0d0b30064d5a42..2895e07e7620c4515ecd0e5d75988e8acaa5fd8a 100644

--- a/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

+++ b/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

@@ -316,7 +316,7 @@ bool ComponentExtensionIMEManagerImpl::ReadEngineComponent(

if (out->display_name.find("__MSG_") == 0) {

const InputMethodNameMap* map = kInputMethodNameMap;

size_t map_size = arraysize(kInputMethodNameMap);

- std::string name = StringToUpperASCII(out->display_name);

+ std::string name = base::StringToUpperASCII(out->display_name);

const InputMethodNameMap map_key = {name.c_str(), 0};

const InputMethodNameMap* p =

std::lower_bound(map, map + map_size, map_key);