Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/autocomplete/search_provider.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.cc
diff --git a/chrome/browser/autocomplete/search_provider.cc b/chrome/browser/autocomplete/search_provider.cc
index 9d062749592927769a9bf8d3610ece1863f8325c..2b0595b2afaa07c2a5bbd2711f50826d1c448a98 100644
--- a/chrome/browser/autocomplete/search_provider.cc
+++ b/chrome/browser/autocomplete/search_provider.cc
@@ -567,9 +567,9 @@ bool SearchProvider::IsQuerySuitableForSuggest() const {
// and happens to currently be invalid -- in which case we again want to run
// our checks below. Other QUERY cases are less likely to be URLs and thus we
// assume we're OK.
- if (!LowerCaseEqualsASCII(input_.scheme(), url::kHttpScheme) &&
- !LowerCaseEqualsASCII(input_.scheme(), url::kHttpsScheme) &&
- !LowerCaseEqualsASCII(input_.scheme(), url::kFtpScheme))
+ if (!base::LowerCaseEqualsASCII(input_.scheme(), url::kHttpScheme) &&
+ !base::LowerCaseEqualsASCII(input_.scheme(), url::kHttpsScheme) &&
+ !base::LowerCaseEqualsASCII(input_.scheme(), url::kFtpScheme))
return (input_.type() == metrics::OmniboxInputType::QUERY);
// Don't send URLs with usernames, queries or refs. Some of these are
@@ -591,7 +591,7 @@ bool SearchProvider::IsQuerySuitableForSuggest() const {
// Don't send anything for https except the hostname. Hostnames are OK
// because they are visible when the TCP connection is established, but the
// specific path may reveal private information.
- if (LowerCaseEqualsASCII(input_.scheme(), url::kHttpsScheme) &&
+ if (base::LowerCaseEqualsASCII(input_.scheme(), url::kHttpsScheme) &&
parts.path.is_nonempty())
return false;

Powered by Google App Engine
This is Rietveld 408576698