chrome/installer/setup/install_worker.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install_worker.cc

diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc

index 727d4fe09c2092380dfa557352354f21c60c124c..2c6c27a14e4383663afd553e919ee05cbd9238e0 100644

--- a/chrome/installer/setup/install_worker.cc

+++ b/chrome/installer/setup/install_worker.cc

@@ -842,7 +842,7 @@ void AddVersionKeyWorkItems(HKEY root,

// languages is a superset of Chrome's set of translations with this one

// exception: what Chrome calls "en-us", Omaha calls "en". sigh.

base::string16 language(GetCurrentTranslation());

- if (LowerCaseEqualsASCII(language, "en-us"))

+ if (base::LowerCaseEqualsASCII(language, "en-us"))

language.resize(2);

list->AddSetRegValueWorkItem(root,

version_key,

« no previous file with comments | « chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc ('k') | chrome/installer/util/l10n_string_util.cc » ('j') | no next file with comments »