chrome/browser/ui/app_list/search/webstore/webstore_provider.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/common/webservice_search_provider.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

diff --git a/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc b/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

index da9a25f25bff19b0176fff515d81c1ea4a960666..1492ec88dd8e0dbb634354d2da4f203521b0aa3a 100644

--- a/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

+++ b/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc

@@ -37,13 +37,13 @@ const char kLegacyPackagedAppType[] = "legacy_packaged_app";

// Converts the item type string from the web store to an

// extensions::Manifest::Type.

extensions::Manifest::Type ParseItemType(const std::string& item_type_str) {

- if (LowerCaseEqualsASCII(item_type_str, kPlatformAppType))

+ if (base::LowerCaseEqualsASCII(item_type_str, kPlatformAppType))

return extensions::Manifest::TYPE_PLATFORM_APP;

- if (LowerCaseEqualsASCII(item_type_str, kLegacyPackagedAppType))

+ if (base::LowerCaseEqualsASCII(item_type_str, kLegacyPackagedAppType))

return extensions::Manifest::TYPE_LEGACY_PACKAGED_APP;

- if (LowerCaseEqualsASCII(item_type_str, kHostedAppType))

+ if (base::LowerCaseEqualsASCII(item_type_str, kHostedAppType))

return extensions::Manifest::TYPE_HOSTED_APP;

return extensions::Manifest::TYPE_UNKNOWN;