chrome/browser/themes/theme_properties.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_properties.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_url_filter.cc ('k') | chrome/browser/ui/app_list/search/common/webservice_search_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/theme_properties.cc

diff --git a/chrome/browser/themes/theme_properties.cc b/chrome/browser/themes/theme_properties.cc

index 180782258136422b674ed19a1727f1fe0de8a4d4..f401a3762ad5fc2410b492f4d59ea6748f38a194 100644

--- a/chrome/browser/themes/theme_properties.cc

+++ b/chrome/browser/themes/theme_properties.cc

@@ -143,13 +143,13 @@ int ThemeProperties::StringToAlignment(const std::string& alignment) {

int alignment_mask = 0;

for (std::vector<std::string>::iterator component(split.begin());

component != split.end(); ++component) {

- if (LowerCaseEqualsASCII(*component, kAlignmentTop))

+ if (base::LowerCaseEqualsASCII(*component, kAlignmentTop))

alignment_mask |= ALIGN_TOP;

- else if (LowerCaseEqualsASCII(*component, kAlignmentBottom))

+ else if (base::LowerCaseEqualsASCII(*component, kAlignmentBottom))

alignment_mask |= ALIGN_BOTTOM;

- else if (LowerCaseEqualsASCII(*component, kAlignmentLeft))

+ else if (base::LowerCaseEqualsASCII(*component, kAlignmentLeft))

alignment_mask |= ALIGN_LEFT;

- else if (LowerCaseEqualsASCII(*component, kAlignmentRight))

+ else if (base::LowerCaseEqualsASCII(*component, kAlignmentRight))

alignment_mask |= ALIGN_RIGHT;

}

return alignment_mask;