chrome/browser/ssl/ssl_browser_tests.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/malware_details_cache.cc ('k') | chrome/browser/supervised_user/supervised_user_url_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index 31dcbd8f88ad23f2d2482e6e6963896c8aa6a466..3d8de5b19757a41bf1d7857bc84839423fae9d01 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -677,7 +677,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, MAYBE_TestWSSInvalidCertAndClose) {

// The title will be changed to 'PASS'.

ui_test_utils::NavigateToURL(browser(), master_url);

const base::string16 result = watcher.WaitAndGetTitle();

- EXPECT_TRUE(LowerCaseEqualsASCII(result, "pass"));

+ EXPECT_TRUE(base::LowerCaseEqualsASCII(result, "pass"));

// Close tabs which contains the test page.

for (int i = 0; i < 16; ++i)

@@ -714,7 +714,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestWSSInvalidCertAndGoForward) {

// Test page run a WebSocket wss connection test. The result will be shown

// as page title.

const base::string16 result = watcher.WaitAndGetTitle();

- EXPECT_TRUE(LowerCaseEqualsASCII(result, "pass"));

+ EXPECT_TRUE(base::LowerCaseEqualsASCII(result, "pass"));

}

#if defined(USE_NSS)

@@ -802,7 +802,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITestWithClientCert, TestWSSClientCert) {

// Test page runs a WebSocket wss connection test. The result will be shown

// as page title.

const base::string16 result = watcher.WaitAndGetTitle();

- EXPECT_TRUE(LowerCaseEqualsASCII(result, "pass"));

+ EXPECT_TRUE(base::LowerCaseEqualsASCII(result, "pass"));

}

#endif // defined(USE_NSS)

@@ -1750,7 +1750,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITestIgnoreCertErrors, TestWSS) {

// Test page run a WebSocket wss connection test. The result will be shown

// as page title.

const base::string16 result = watcher.WaitAndGetTitle();

- EXPECT_TRUE(LowerCaseEqualsASCII(result, "pass"));

+ EXPECT_TRUE(base::LowerCaseEqualsASCII(result, "pass"));

}

// Verifies that the interstitial can proceed, even if JavaScript is disabled.