chrome/browser/chromeos/input_method/input_method_util.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc ('k') | chrome/browser/download/download_extensions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_util.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_util.cc b/chrome/browser/chromeos/input_method/input_method_util.cc

index 5004f3778179c0249f9f2ee7fbc4bb1d262dd85b..74097385711d4134ab7bb62f0cf6c8dc337551ef 100644

--- a/chrome/browser/chromeos/input_method/input_method_util.cc

+++ b/chrome/browser/chromeos/input_method/input_method_util.cc

@@ -381,7 +381,7 @@ base::string16 InputMethodUtil::GetInputMethodShortName(

const size_t kMaxLanguageNameLen = 2;

DCHECK(!input_method.language_codes().empty());

const std::string language_code = input_method.language_codes().at(0);

- text = StringToUpperASCII(base::UTF8ToUTF16(language_code)).substr(

+ text = base::StringToUpperASCII(base::UTF8ToUTF16(language_code)).substr(

0, kMaxLanguageNameLen);

}

DCHECK(!text.empty()) << input_method.id();