Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 448123003: RawChannel::OnWriteCompletedNoLock(): change a DCHECK to CHECK. (Closed)

Created:
6 years, 4 months ago by yzshen1
Modified:
6 years, 4 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

RawChannel::OnWriteCompletedNoLock(): change a DCHECK to CHECK. This is where things go wrong and cause crbug.com/385795 BUG=385795 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/system/raw_channel.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, Trung. Please take a look. Thanks!
6 years, 4 months ago (2014-08-07 17:47:34 UTC) #1
viettrungluu
lgtm
6 years, 4 months ago (2014-08-07 18:24:31 UTC) #2
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 4 months ago (2014-08-07 19:07:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/448123003/1
6 years, 4 months ago (2014-08-07 19:12:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 22:42:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 01:25:31 UTC) #6
Message was sent while issue was closed.
Change committed as 288195

Powered by Google App Engine
This is Rietveld 408576698