Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 448113002: Minor simplification and cleanup of graph builder. (Closed)

Created:
6 years, 4 months ago by Michael Starzinger
Modified:
6 years, 4 months ago
Reviewers:
titzer, rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Minor simplification and cleanup of graph builder. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -50 lines) Patch
M src/compiler/ast-graph-builder.h View 4 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +5 lines, -16 lines 0 comments Download
M src/compiler/control-builders.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-builder.h View 2 chunks +1 line, -7 lines 0 comments Download
M src/compiler/graph-builder.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M test/cctest/compiler/simplified-graph-builder.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 4 months ago (2014-08-07 10:07:51 UTC) #1
rossberg
lgtm
6 years, 4 months ago (2014-08-08 13:38:01 UTC) #2
Michael Starzinger
6 years, 4 months ago (2014-08-08 13:51:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23000 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698