autotest: enable and verify write protection by status registers

autotest: enable and verify write protection by status registers

Bit-by-bit verification (hardware_EepromWriteProtect) should be only in
qualification process; in factory process, we only need to check if the WP
status registers are correctly configured and protected.

BUG=chrome-os-partner:1569
TEST=manually executed on a device with following conditions:
 (1) hardware WP=off => test failed (expected)
 (2) hardware WP=on, software WP=off => test pass, WP enabled
 (3) hardware WP=on, software WP=on, range set to correct => test pass
 (4) hardware WP=on, software WP=on, range set to incorrect => test fail (expected)

Change-Id: I1b104ead04cb7799806514f04142bf623e775e8e

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2d11f27

[Nick Sanders, 2010-11-04 09:48:55]

lgtm w/ added comments. thanks for the quick work!

http://codereview.chromium.org/4481001/diff/1/3
File client/site_tests/factory_EnableWriteProtect/factory_EnableWriteProtect.py
(right):

http://codereview.chromium.org/4481001/diff/1/3#newcode80
client/site_tests/factory_EnableWriteProtect/factory_EnableWriteProtect.py:80:
if (not (self.flashrom.verify_write_protect(layout, 'ro') or
Can you add a comment on the sequence here, looks fine but a bit hard to figure
out in a quick glance.

if not verify, 
  enable 
  if not verify, 
    fail

[Hung-Te, 2010-11-04 10:19:59]

http://codereview.chromium.org/4481001/diff/1/3
File client/site_tests/factory_EnableWriteProtect/factory_EnableWriteProtect.py
(right):

http://codereview.chromium.org/4481001/diff/1/3#newcode80
client/site_tests/factory_EnableWriteProtect/factory_EnableWriteProtect.py:80:
if (not (self.flashrom.verify_write_protect(layout, 'ro') or
On 2010/11/04 09:48:56, Nick Sanders wrote:
> Can you add a comment on the sequence here, looks fine but a bit hard to
figure
> out in a quick glance.
> 
> if not verify, 
>   enable 
>   if not verify, 
>     fail

Done.

[Tammo Spalink, 2010-11-04 10:41:06]

lgtm