Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 448093002: Extend some operations to range types. (Closed)

Created:
6 years, 4 months ago by neis
Modified:
6 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Extend some operations to range types. This is a reland of 22945, which failed to build on Windows due to (some versions of?) Visual Studio lacking copysign(). R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22977

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -16 lines) Patch
M src/types.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/types.cc View 9 chunks +52 lines, -2 lines 1 comment Download
M test/cctest/test-types.cc View 5 chunks +26 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
neis
6 years, 4 months ago (2014-08-07 08:34:23 UTC) #1
rossberg
LGTM with nit https://codereview.chromium.org/448093002/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/448093002/diff/1/src/types.cc#newcode19 src/types.cc:19: return x <= y && (!IsMinusZero(y) ...
6 years, 4 months ago (2014-08-07 14:12:57 UTC) #2
neis
6 years, 4 months ago (2014-08-07 15:30:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698